emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Ian Kelling <ian@iankelling.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make the point visible when jumping to the mark
Date: Wed, 21 May 2014 15:00:36 +0200	[thread overview]
Message-ID: <87lhtvwakr.fsf@bzg.ath.cx> (raw)
In-Reply-To: <874n1aq9y5.fsf@treetowl.lan> (Ian Kelling's message of "Wed, 30 Apr 2014 21:54:08 -0700")

Hi Ian,

Please send me your public key so that I can give you access to the
org-mode and worg repositories.

Ian Kelling <ian@iankelling.org> writes:

> From 9191e4a364e251119cf8b7c72e41f6c0d09583f2 Mon Sep 17 00:00:00 2001
> Message-ID: <87ha5aqa93.fsf@treetowl.lan>
> MIME-Version: 1.0
> Content-Type: text/plain
>
> *lisp/org.el: Advise commands which jump to the mark

The formatting of the Changelog message not good.

It should be

* org.el: Advise commands which jump to the mark.

See http://orgmode.org/worg/org-contribute.html and example in
the git logs.

> +(eval-after-load "simple"
> +  '(defadvice set-mark-command (after org-make-visible activate)
> +     "Make the point visible with `org-show-context'."
> +     (org-mark-jump-unhide)))

Why this one?  The user don't want to use C-SPC in hidden parts.

> +(eval-after-load "simple"
> +  '(defadvice exchange-point-and-mark (after org-make-visible activate)
> +     "Make the point visible with `org-show-context'."
> +     (org-mark-jump-unhide)))

> +(eval-after-load "simple"
> +  '(defadvice pop-global-mark (after org-make-visible activate)
> +     "Make the point visible with `org-show-context'."
> +     (org-mark-jump-unhide)))

This two ones are good, yes.

Thanks,

-- 
 Bastien

  parent reply	other threads:[~2014-05-21 13:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01  4:54 [PATCH] Make the point visible when jumping to the mark Ian Kelling
2014-05-20 22:25 ` Ian Kelling
2014-05-21  2:58   ` Bastien
2014-05-21  9:21     ` Ian Kelling
2014-05-21 13:00 ` Bastien [this message]
2014-05-21 19:01   ` Ian Kelling
2014-05-22  9:54     ` Bastien
2014-05-22  8:56   ` Sebastien Vauban
2014-05-22  9:52     ` Bastien
2014-05-22 15:40       ` Ian Kelling
2014-05-23  5:47         ` Bastien
  -- strict thread matches above, loose matches on Subject: below --
2013-09-15  9:22 Ian Kelling
2013-09-15 17:25 ` Ian Kelling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhtvwakr.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=ian@iankelling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).