From: Ian Kelling <ian@iankelling.org>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make the point visible when jumping to the mark
Date: Tue, 20 May 2014 15:25:58 -0700 [thread overview]
Message-ID: <87vbt0f5op.fsf@treetowl.lan> (raw)
In-Reply-To: <874n1aq9y5.fsf@treetowl.lan> (Ian Kelling's message of "Wed, 30 Apr 2014 21:54:08 -0700")
> From 9191e4a364e251119cf8b7c72e41f6c0d09583f2 Mon Sep 17 00:00:00 2001
> Message-ID: <87ha5aqa93.fsf@treetowl.lan>
> MIME-Version: 1.0
> Content-Type: text/plain
>
> *lisp/org.el: Advise commands which jump to the mark
> ---
>
> There are several non-org commands that jump to a location and would be
> unwieldy if the location remained hidden, (isearch, bookmark-jump,
> save-place), but org-mode has code to fix them. In this patch, I
> followed their example.
>
> I have an emacs fsf copyright assignment completed & on file with fsf, I can
> send gpg signed copy if you need it.
>
> - Ian Kelling
>
>
> lisp/org.el | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 44a4e44..9365059 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -24326,6 +24326,27 @@ To get rid of the restriction, use \\[org-agenda-remove-restriction-lock]."
> (outline-invisible-p)))
> (org-show-context 'bookmark-jump)))
>
> +(eval-after-load "simple"
> + '(defadvice set-mark-command (after org-make-visible activate)
> + "Make the point visible with `org-show-context'."
> + (org-mark-jump-unhide)))
> +
> +(eval-after-load "simple"
> + '(defadvice exchange-point-and-mark (after org-make-visible activate)
> + "Make the point visible with `org-show-context'."
> + (org-mark-jump-unhide)))
> +
> +(eval-after-load "simple"
> + '(defadvice pop-global-mark (after org-make-visible activate)
> + "Make the point visible with `org-show-context'."
> + (org-mark-jump-unhide)))
> +
> +(defun org-mark-jump-unhide ()
> + "Make the point visible with `org-show-context' after jumping to the mark."
> + (when (and (derived-mode-p 'org-mode)
> + (outline-invisible-p))
> + (org-show-context 'mark-goto)))
> +
> ;; Make session.el ignore our circular variable
> (defvar session-globals-exclude)
> (eval-after-load "session"
I posted this patch in September. It seems it was forgotten. I posted it
again on April 30th, nothing yet. I also have another patch thats been
sitting on the list for a few weeks now after having a discussion and a
positive response. I'd like to do a git pull and find my patches applied
at some point, and I'm wondering if/when that will happen. And is there
anything I can do to help?
- Ian Kelling
next prev parent reply other threads:[~2014-05-20 22:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 4:54 [PATCH] Make the point visible when jumping to the mark Ian Kelling
2014-05-20 22:25 ` Ian Kelling [this message]
2014-05-21 2:58 ` Bastien
2014-05-21 9:21 ` Ian Kelling
2014-05-21 13:00 ` Bastien
2014-05-21 19:01 ` Ian Kelling
2014-05-22 9:54 ` Bastien
2014-05-22 8:56 ` Sebastien Vauban
2014-05-22 9:52 ` Bastien
2014-05-22 15:40 ` Ian Kelling
2014-05-23 5:47 ` Bastien
-- strict thread matches above, loose matches on Subject: below --
2013-09-15 9:22 Ian Kelling
2013-09-15 17:25 ` Ian Kelling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbt0f5op.fsf@treetowl.lan \
--to=ian@iankelling.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).