From: Ian Kelling <ian@iankelling.org>
To: Bastien <bzg@gnu.org>
Cc: Sebastien Vauban
<public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org>,
emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make the point visible when jumping to the mark
Date: Thu, 22 May 2014 08:40:07 -0700 [thread overview]
Message-ID: <87y4xt4yaw.fsf@treetowl.lan> (raw)
In-Reply-To: <87r43m87in.fsf@bzg.ath.cx> (Bastien's message of "Thu, 22 May 2014 11:52:48 +0200")
Bastien <bzg@gnu.org> writes:
> Hi Sébastien,
>
> Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
> writes:
>
>> Even if the goal is desirable, I thought that we may not add defadvice
>> in Emacs sources.
>
> True that, we need to clean things up.
>
> The route I will take is to apply Ian patch on master and then to
> move all advising code into a separate org-advice.el library in the
> contrib/ directory. Any suggestion for a better name?
I considered this problem when I made the patch, and originally started
writing it to not use advise. The alternative I see is to create
org-mode versions of these functions, and binding them with the
org-mode-map to override the existing functions, like we do with other
functions. I prefer advice in these cases because the advice is simple
and it is easier for users customizing keybinds and extending
emacs. However, compared to making it a module and thus not enabled by
default, I would prefer to make org-mode versions of the
functions. Having them on by default will be more helpful to more users
overall. I would be happy to write the patch for this, if we agree.
next prev parent reply other threads:[~2014-05-22 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 4:54 [PATCH] Make the point visible when jumping to the mark Ian Kelling
2014-05-20 22:25 ` Ian Kelling
2014-05-21 2:58 ` Bastien
2014-05-21 9:21 ` Ian Kelling
2014-05-21 13:00 ` Bastien
2014-05-21 19:01 ` Ian Kelling
2014-05-22 9:54 ` Bastien
2014-05-22 8:56 ` Sebastien Vauban
2014-05-22 9:52 ` Bastien
2014-05-22 15:40 ` Ian Kelling [this message]
2014-05-23 5:47 ` Bastien
-- strict thread matches above, loose matches on Subject: below --
2013-09-15 9:22 Ian Kelling
2013-09-15 17:25 ` Ian Kelling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4xt4yaw.fsf@treetowl.lan \
--to=ian@iankelling.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).