emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jambunathan K <kjambunathan@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [New Exporter] Parameterized wrapper elements
Date: Sat, 09 Mar 2013 22:45:52 +0530	[thread overview]
Message-ID: <87k3pgsddj.fsf@gmail.com> (raw)
In-Reply-To: <20130309163908.GA25341@BigDog.local> (Rick Frankel's message of "Sat, 9 Mar 2013 11:39:08 -0500")

Rick

I have my reservations in applying this patch - I am not concerned about
the patch, I have not looked at it.  

Any improvements to existing backends should invariably answer the
question - "Can this change improve export tools or the parse tree
syntax."

If such a question is never asked and a answer sought, I would blame the
committer - whoever it be - in placing convenience and expediency above
the correct way to do things.

I have not looked at Rick's patch so my comment shouldn't be construed
as disapproval of the patch.  I want the patch to improve exporter tools
and it has potential to improve the existing tools (maybe) in small ways
- an improvement is an improvement.

Jambunathan K.

Rick Frankel <rick@rickster.com> writes:

> On Sat, Mar 09, 2013 at 10:32:11AM +0100, Bastien wrote:
>> Hi Rick,
>
>> One thing you may double-check in the meantime is: is it
>> compatible with the org-info.js utility?  The default should
>> be "yes", even if users can replace "div" by something else
>> (e.g. for the needs of specific backends.)
>
> Yes. Checked the code and tested the script. It works on element ids
> and not element types, so changing the element type from `div' has no
> effect.
>
> The things that will break infojs are changing the following ids:
>
>     - content
>     - postamble
>     - footnotes
>     - table-of-contents
>     - text-table-of-content
>     - text-{slidenum}
>               
> Note that the current implementation of `org-html-divs' will
> potentially break infojs as well.
>
> Attached is a revised patch with the fixes Nicolas found for the
> doc-string and the missing closing element.
>
> rick
>

-- 

      reply	other threads:[~2013-03-09 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09  0:17 [New Exporter] Parameterized wrapper elements Rick Frankel
2013-03-09  0:46 ` Nicolas Goaziou
2013-03-09 16:07   ` Rick Frankel
2013-03-09  2:33 ` Jambunathan K
2013-03-09  9:32 ` Bastien
2013-03-09 16:39   ` Rick Frankel
2013-03-09 17:15     ` Jambunathan K [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3pgsddj.fsf@gmail.com \
    --to=kjambunathan@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).