From: Rick Frankel <rick@rickster.com>
To: emacs-orgmode@gnu.org
Subject: Re: [New Exporter] Parameterized wrapper elements
Date: Sat, 9 Mar 2013 11:07:45 -0500 [thread overview]
Message-ID: <20130309160745.GA24696@BigDog.local> (raw)
In-Reply-To: <87li9xz9g2.fsf@gmail.com>
On Sat, Mar 09, 2013 at 01:46:37AM +0100, Nicolas Goaziou wrote:
> Since I don't use html back-end, it would be better to hear from actual
> users what they think about it.
Sorry, forgot that you are not the keeper of ox-html, just the new
exporter at large ;).
> Anyway, just a few comments:
>
> > +(defcustom org-html-divs
> > + '(("preamble" "div")
> > + ("content" "div")
> > + ("postamble" "div"))
> > + "Alist of the main divs for HTML export.
> Even if this is technically an alist, you don't use it as such, because
> you do not treat ID as keys.
>
> Perhaps something like the following would be better:
>
> '((preamble "preamble" "div")
> (content "content" "div")
> (postamble "postamble" "div"))
>
> One advantage is that you don't have to rely on order of associations.
> Another advantage is that you can write:
>
> (nth 1 (assq 'content org-html-divs))
I agree, but couldn't figure out a way to specify a defcustom alist
that requires a fixed set of options. I'm quite new to the
defcustom specification format, so maybe there is a way...
Given what I see is possible w/ custom alists, the code would have to
look like:
(nth 1 (or (assq 'content org-html-divs)
(assq 'content org-html-default-divs)))
Not sure this is any better than the nth nth approach. What do you
think?
> > + (if (= 1 (org-export-get-relative-level headline info))
> > + (plist-get info :html-container))))))))
>
> Shouldn't you close the div when level is different from 1 here?
Yes, it's a bug. Missing the else part. Will amend the patch and
repost. thanx for finding this.
rick
next prev parent reply other threads:[~2013-03-09 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 0:17 [New Exporter] Parameterized wrapper elements Rick Frankel
2013-03-09 0:46 ` Nicolas Goaziou
2013-03-09 16:07 ` Rick Frankel [this message]
2013-03-09 2:33 ` Jambunathan K
2013-03-09 9:32 ` Bastien
2013-03-09 16:39 ` Rick Frankel
2013-03-09 17:15 ` Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309160745.GA24696@BigDog.local \
--to=rick@rickster.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).