From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: Re: [New Exporter] Parameterized wrapper elements Date: Sat, 09 Mar 2013 22:45:52 +0530 Message-ID: <87k3pgsddj.fsf@gmail.com> References: <20130309001710.GB22813@BigDog.local> <871ubo3omc.fsf@bzg.ath.cx> <20130309163908.GA25341@BigDog.local> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:47249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UENNH-0006xP-7W for emacs-orgmode@gnu.org; Sat, 09 Mar 2013 12:16:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UENNA-0000sQ-SZ for emacs-orgmode@gnu.org; Sat, 09 Mar 2013 12:15:59 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:43772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UENNA-0000sD-LS for emacs-orgmode@gnu.org; Sat, 09 Mar 2013 12:15:52 -0500 Received: by mail-pb0-f46.google.com with SMTP id uo15so2282576pbc.5 for ; Sat, 09 Mar 2013 09:15:51 -0800 (PST) In-Reply-To: <20130309163908.GA25341@BigDog.local> (Rick Frankel's message of "Sat, 9 Mar 2013 11:39:08 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Rick I have my reservations in applying this patch - I am not concerned about the patch, I have not looked at it. Any improvements to existing backends should invariably answer the question - "Can this change improve export tools or the parse tree syntax." If such a question is never asked and a answer sought, I would blame the committer - whoever it be - in placing convenience and expediency above the correct way to do things. I have not looked at Rick's patch so my comment shouldn't be construed as disapproval of the patch. I want the patch to improve exporter tools and it has potential to improve the existing tools (maybe) in small ways - an improvement is an improvement. Jambunathan K. Rick Frankel writes: > On Sat, Mar 09, 2013 at 10:32:11AM +0100, Bastien wrote: >> Hi Rick, > >> One thing you may double-check in the meantime is: is it >> compatible with the org-info.js utility? The default should >> be "yes", even if users can replace "div" by something else >> (e.g. for the needs of specific backends.) > > Yes. Checked the code and tested the script. It works on element ids > and not element types, so changing the element type from `div' has no > effect. > > The things that will break infojs are changing the following ids: > > - content > - postamble > - footnotes > - table-of-contents > - text-table-of-content > - text-{slidenum} > > Note that the current implementation of `org-html-divs' will > potentially break infojs as well. > > Attached is a revised patch with the fixes Nicolas found for the > doc-string and the missing closing element. > > rick > --