emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Timothy <tecosaur@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Matt Huszagh <huszaghmatt@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix window width when line numbers present
Date: Mon, 22 Nov 2021 11:16:52 +0800	[thread overview]
Message-ID: <87h7c47u8b.fsf@gmail.com> (raw)
In-Reply-To: <87zgpxtdx2.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> `line-number-display-width’ is Emacs 26+. So I guess it is unfortunately
> not acceptable on main branch.

Ooops, thanks for picking that up Nicolas. I see we actually have
┌────
│ (if (fboundp 'line-number-display-width)
│     (defalias 'org-line-number-display-width 'line-number-display-width)
│   (defun org-line-number-display-width (&rest _) 0))
└────
in org-compat.el, but I think that fallback definition could be improved — even
just `(or display-line-numbers-width 0)' would be better.

All the best,
Timothy

  parent reply	other threads:[~2021-11-22  3:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 18:41 [PATCH] Fix window width when line numbers present Matt Huszagh
2021-11-21 19:14 ` Timothy
2021-11-21 21:08   ` Nicolas Goaziou
2021-11-21 21:14     ` Matt Huszagh
2021-11-21 21:16       ` Bastien
2021-11-21 21:22         ` Matt Huszagh
2021-11-22  5:14           ` Bastien
2021-11-22  5:31             ` Timothy
2021-11-22  5:44               ` Bastien
2021-11-22  5:51                 ` Supported Emacs version (was: [PATCH] Fix window width when line numbers present) Timothy
2021-11-22  6:05                   ` Supported Emacs version Bastien
2021-11-22  6:12                     ` Timothy
2021-11-22  6:39                       ` Bastien
2021-11-22  8:04                         ` Timothy
2021-11-22 10:26                           ` Bastien
2021-11-22 11:55                 ` [PATCH] Fix window width when line numbers present Ihor Radchenko
2021-11-22 12:40                   ` Tim Cross
2021-11-23  5:59                   ` Bastien
2021-11-23  7:05                     ` Tim Cross
2021-11-22  3:16     ` Timothy [this message]
2021-11-21 19:19 ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7c47u8b.fsf@gmail.com \
    --to=tecosaur@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=huszaghmatt@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).