emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Exporting with block agenda
@ 2008-07-22 17:49 Jan Seeger
  2008-07-22 18:09 ` Carsten Dominik
  2008-07-22 19:30 ` Carsten Dominik
  0 siblings, 2 replies; 8+ messages in thread
From: Jan Seeger @ 2008-07-22 17:49 UTC (permalink / raw)
  To: emacs-orgmode

Greetings,

I almost went crazy today trying to export my block agenda. I had my
agenda set up like this:

	  (setq org-agenda-custom-commands '(
	  							   ("c" "" 
	  								((todo "NEXT|TODO") (agenda))
	  								((org-agenda-with-colors nil)
	  								 (ps-font-size '(8 . 8))
	  								 (org-agenda-compact-blocks t)
	  								 (ps-landscape-mode t)
	  								 (ps-number-of-columns 2)
	  								 )
	  								("/tmp/todo-list.ps")
	  								)
	  	  ))
		  
, which seemed correct (show todos and an agenda together and export
it to the /tmp/todo-list.ps file. However, orgmode refused to export
the agenda. Looking at org-agenda.el, I edebugged
org-batch-store-agenda-views, and saw that in line 1774, block agendas
are (seemingly) not parsed correctly. With the syntax from the
documentation and! customize-variable, file and settings are the third
and fourth elements respectively.

So I inserted a nil between the commands and the settings, and my
block agenda miraculously exported.

Is the above setting wrong, or is that a bug in org-mode? (I'm using
6.04c with emacs 22.2-r2).

Regards,
Jan Seeger

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 17:49 Exporting with block agenda Jan Seeger
@ 2008-07-22 18:09 ` Carsten Dominik
  2008-07-22 18:53   ` Jan Seeger
  2008-07-22 19:30 ` Carsten Dominik
  1 sibling, 1 reply; 8+ messages in thread
From: Carsten Dominik @ 2008-07-22 18:09 UTC (permalink / raw)
  To: Jan Seeger; +Cc: emacs-orgmode


On Jul 22, 2008, at 10:49 AM, Jan Seeger wrote:

> Greetings,
>
> I almost went crazy today trying to export my block agenda. I had my
> agenda set up like this:
>
> 	  (setq org-agenda-custom-commands '(
> 	  							   ("c" ""
> 	  								((todo "NEXT|TODO") (agenda))
> 	  								((org-agenda-with-colors nil)
> 	  								 (ps-font-size '(8 . 8))
> 	  								 (org-agenda-compact-blocks t)
> 	  								 (ps-landscape-mode t)
> 	  								 (ps-number-of-columns 2)
> 	  								 )
> 	  								("/tmp/todo-list.ps")
> 	  								)
> 	  	  ))
> 		
> , which seemed correct (show todos and an agenda together and export
> it to the /tmp/todo-list.ps file. However, orgmode refused to export
> the agenda. Looking at org-agenda.el, I edebugged
> org-batch-store-agenda-views, and saw that in line 1774, block agendas
> are (seemingly) not parsed correctly. With the syntax from the
> documentation and! customize-variable, file and settings are the third
> and fourth elements respectively.
>
> So I inserted a nil between the commands and the settings, and my
> block agenda miraculously exported.
>
> Is the above setting wrong

The setting is wrong.  Parameters in org-agenda-custom-commands are  
identified by
position, and your file list is seen as an attempt to set options  
(variables)
for the command set.  You need nil there.

Can you identify a point in the documentation that made you assume you  
could write things a you did?

Thanks.

- Carsten



> or is that a bug in org-mode? (I'm using
> 6.04c with emacs 22.2-r2).
>
> Regards,
> Jan Seeger
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 18:09 ` Carsten Dominik
@ 2008-07-22 18:53   ` Jan Seeger
  2008-07-22 19:10     ` Carsten Dominik
  0 siblings, 1 reply; 8+ messages in thread
From: Jan Seeger @ 2008-07-22 18:53 UTC (permalink / raw)
  To: emacs-orgmode

At Tue, 22 Jul 2008 11:09:22 -0700,
Carsten Dominik wrote:
> 
> 
> On Jul 22, 2008, at 10:49 AM, Jan Seeger wrote:
> > 	  (setq org-agenda-custom-commands '(
> > 	  							   ("c" ""
> > 	  								((todo "NEXT|TODO") (agenda))
> > 	  								((org-agenda-with-colors nil)
> > 	  								 (ps-font-size '(8 . 8))
> > 	  								 (org-agenda-compact-blocks t)
> > 	  								 (ps-landscape-mode t)
> > 	  								 (ps-number-of-columns 2)
> > 	  								 )
> > 	  								("/tmp/todo-list.ps")
> > 	  								)
> > 	  	  ))
> The setting is wrong.  Parameters in org-agenda-custom-commands are  
> identified by
> position, and your file list is seen as an attempt to set options  
> (variables)
> for the command set.  You need nil there.
> 
> Can you identify a point in the documentation that made you assume you  
> could write things a you did?

Quote from C-h v org-agenda-custom-commands: 

>  You can also define a set of commands, to create a composite agenda buffer.
>  In this case, an entry looks like this:
>
>    (key desc (cmd1 cmd2 ...) general-settings-for-whole-set files)

This looks to me as if only four elements where needed: Key,
description, list of lists of commands (agenda,alltodo etc), settings
and filenames.

Regards,
Jan
--
Warning! Erwin Schrödinger will kill you like a cat in a box.
Maybe.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 18:53   ` Jan Seeger
@ 2008-07-22 19:10     ` Carsten Dominik
  0 siblings, 0 replies; 8+ messages in thread
From: Carsten Dominik @ 2008-07-22 19:10 UTC (permalink / raw)
  To: Jan Seeger; +Cc: emacs-orgmode

You are completely right.  This is a bug in Org-mode.

- Carsten

On Jul 22, 2008, at 11:53 AM, Jan Seeger wrote:

> At Tue, 22 Jul 2008 11:09:22 -0700,
> Carsten Dominik wrote:
>>
>>
>> On Jul 22, 2008, at 10:49 AM, Jan Seeger wrote:
>>> 	  (setq org-agenda-custom-commands '(
>>> 	  							   ("c" ""
>>> 	  								((todo "NEXT|TODO") (agenda))
>>> 	  								((org-agenda-with-colors nil)
>>> 	  								 (ps-font-size '(8 . 8))
>>> 	  								 (org-agenda-compact-blocks t)
>>> 	  								 (ps-landscape-mode t)
>>> 	  								 (ps-number-of-columns 2)
>>> 	  								 )
>>> 	  								("/tmp/todo-list.ps")
>>> 	  								)
>>> 	  	  ))
>> The setting is wrong.  Parameters in org-agenda-custom-commands are
>> identified by
>> position, and your file list is seen as an attempt to set options
>> (variables)
>> for the command set.  You need nil there.
>>
>> Can you identify a point in the documentation that made you assume  
>> you
>> could write things a you did?
>
> Quote from C-h v org-agenda-custom-commands:
>
>> You can also define a set of commands, to create a composite agenda  
>> buffer.
>> In this case, an entry looks like this:
>>
>>   (key desc (cmd1 cmd2 ...) general-settings-for-whole-set files)
>
> This looks to me as if only four elements where needed: Key,
> description, list of lists of commands (agenda,alltodo etc), settings
> and filenames.
>
> Regards,
> Jan
> --
> Warning! Erwin Schrödinger will kill you like a cat in a box.
> Maybe.
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 17:49 Exporting with block agenda Jan Seeger
  2008-07-22 18:09 ` Carsten Dominik
@ 2008-07-22 19:30 ` Carsten Dominik
  2008-07-22 19:59   ` Jan Seeger
                     ` (2 more replies)
  1 sibling, 3 replies; 8+ messages in thread
From: Carsten Dominik @ 2008-07-22 19:30 UTC (permalink / raw)
  To: Jan Seeger; +Cc: emacs-orgmode

Hi Jan,

I just pushed a fix to the git repo, below I include the patch.

Could you please check if this fixed the problem and report back?

Thanks.

- Carsten


diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7a65b62..5440cca 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -1808,7 +1808,7 @@ so the export commands can easily use it."
    (let ((cmds (org-agenda-normalize-custom-commands org-agenda- 
custom-commands))
  	(pop-up-frames nil)
  	(dir default-directory)
-	pars cmd thiscmdkey files opts)
+	pars cmd thiscmdkey files opts cmd-or-set)
      (while parameters
        (push (list (pop parameters) (if parameters (pop parameters)))  
pars))
      (setq pars (reverse pars))
@@ -1816,8 +1816,9 @@ so the export commands can easily use it."
        (while cmds
  	(setq cmd (pop cmds)
  	      thiscmdkey (car cmd)
-	      opts (nth 4 cmd)
-	      files (nth 5 cmd))
+	      cmd-or-set (nth 2 cmd)
+	      opts (nth (if (listp cmd-or-set) 3 4) cmd)
+	      files (nth (if (listp cmd-or-set) 4 5) cmd))
  	(if (stringp files) (setq files (list files)))
  	(when files
  	  (eval (list 'let (append org-agenda-exporter-settings opts pars)


On Jul 22, 2008, at 10:49 AM, Jan Seeger wrote:

> Greetings,
>
> I almost went crazy today trying to export my block agenda. I had my
> agenda set up like this:
>
> 	  (setq org-agenda-custom-commands '(
> 	  							   ("c" ""
> 	  								((todo "NEXT|TODO") (agenda))
> 	  								((org-agenda-with-colors nil)
> 	  								 (ps-font-size '(8 . 8))
> 	  								 (org-agenda-compact-blocks t)
> 	  								 (ps-landscape-mode t)
> 	  								 (ps-number-of-columns 2)
> 	  								 )
> 	  								("/tmp/todo-list.ps")
> 	  								)
> 	  	  ))
> 		
> , which seemed correct (show todos and an agenda together and export
> it to the /tmp/todo-list.ps file. However, orgmode refused to export
> the agenda. Looking at org-agenda.el, I edebugged
> org-batch-store-agenda-views, and saw that in line 1774, block agendas
> are (seemingly) not parsed correctly. With the syntax from the
> documentation and! customize-variable, file and settings are the third
> and fourth elements respectively.
>
> So I inserted a nil between the commands and the settings, and my
> block agenda miraculously exported.
>
> Is the above setting wrong, or is that a bug in org-mode? (I'm using
> 6.04c with emacs 22.2-r2).
>
> Regards,
> Jan Seeger
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 19:30 ` Carsten Dominik
@ 2008-07-22 19:59   ` Jan Seeger
  2008-07-22 20:00   ` Jan Seeger
  2008-07-26 13:27   ` Jan Seeger
  2 siblings, 0 replies; 8+ messages in thread
From: Jan Seeger @ 2008-07-22 19:59 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Yeah, I'll check, at latest friday.

I have an exam tomorrow, so... well.

Regards,
Jan
--
Warning! Erwin Schrödinger will kill you like a cat in a box.
Maybe.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 19:30 ` Carsten Dominik
  2008-07-22 19:59   ` Jan Seeger
@ 2008-07-22 20:00   ` Jan Seeger
  2008-07-26 13:27   ` Jan Seeger
  2 siblings, 0 replies; 8+ messages in thread
From: Jan Seeger @ 2008-07-22 20:00 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Yeah, I'll check, at latest friday.

I have an exam tomorrow, so... well.

Regards,
Jan
--
Warning! Erwin Schrödinger will kill you like a cat in a box.
Maybe.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Exporting with block agenda
  2008-07-22 19:30 ` Carsten Dominik
  2008-07-22 19:59   ` Jan Seeger
  2008-07-22 20:00   ` Jan Seeger
@ 2008-07-26 13:27   ` Jan Seeger
  2 siblings, 0 replies; 8+ messages in thread
From: Jan Seeger @ 2008-07-26 13:27 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Yes, that seems to work correctly.

Many thanks,
Jan Seeger

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-07-26 13:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-22 17:49 Exporting with block agenda Jan Seeger
2008-07-22 18:09 ` Carsten Dominik
2008-07-22 18:53   ` Jan Seeger
2008-07-22 19:10     ` Carsten Dominik
2008-07-22 19:30 ` Carsten Dominik
2008-07-22 19:59   ` Jan Seeger
2008-07-22 20:00   ` Jan Seeger
2008-07-26 13:27   ` Jan Seeger

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).