From: Bernt Hansen <bernt@norang.ca>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: "git describe" in version of info file with "make info_git_describe"
Date: Thu, 02 Jun 2011 10:47:47 -0400 [thread overview]
Message-ID: <87fwnse1d8.fsf@norang.ca> (raw)
In-Reply-To: <BANLkTi=iqzrSHS6QKoehSyZToBzkqFC3HA@mail.gmail.com> (Michael Brand's message of "Thu, 2 Jun 2011 16:11:51 +0200")
Michael Brand <michael.ch.brand@gmail.com> writes:
> Hi Bernt, hi all
>
> I appreciate that org-version adds the output of "git describe" to the
> org-version string if we are running
> from a git repository. Thanks to Bernt et al:
> http://thread.gmane.org/gmane.emacs.orgmode/16620
>
> Now I suggest the same for the info file by using the new target "make
> info_git_describe" instead of "make info" for all who are running from
> a git repository and are not building a release. I am about to finish
> a patch for this but before posting it would like to know the reason
> for "(subst-char-in-string ?- ?. git-version t)" in org-version here:
> http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org.el;h=1ca03f48d86fac71837079f7c3219cb295a9c795;hb=HEAD#l217
>
> Can I remove this substitution of "release_7.5-350-g3433" ->
> "release_7.5.350.g3433" from org-version in my patch or should "make
> info_git_describe" do the same and why?
Hi Michael,
This was purely cosmetic. I didn't like the look of the mixed '.' and
'-' in the version number originally. I think the two reported version
numbers should be consistent between the org-version function and the
documentation version function you are proposing.
If you want to remove the substitution please also do so in the
org-version code so the reported numbers are consistent.
Regards,
--
Bernt
next prev parent reply other threads:[~2011-06-02 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 14:11 "git describe" in version of info file with "make info_git_describe" Michael Brand
2011-06-02 14:47 ` Bernt Hansen [this message]
2011-06-02 15:05 ` Michael Brand
2011-06-02 19:36 ` Michael Brand
2011-10-16 19:12 ` Michael Brand
2011-10-21 14:44 ` Carsten Dominik
2011-10-21 16:13 ` Bernt Hansen
2011-10-23 22:50 ` Bernt Hansen
2011-10-26 16:07 ` Michael Brand
2011-10-26 16:56 ` Achim Gratz
2011-10-27 18:24 ` Michael Brand
2011-10-28 9:26 ` Achim Gratz
2011-10-29 11:40 ` Michael Brand
2011-10-30 7:01 ` Achim Gratz
2011-10-30 14:20 ` Michael Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwnse1d8.fsf@norang.ca \
--to=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=michael.ch.brand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).