From: Ihor Radchenko <yantar92@gmail.com>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: Max Nikulin <manikulin@gmail.com>,
emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description
Date: Tue, 13 Sep 2022 21:08:56 +0800 [thread overview]
Message-ID: <87bkrjctg7.fsf@localhost> (raw)
In-Reply-To: <8735e091pn.fsf@localhost>
Ihor Radchenko <yantar92@gmail.com> writes:
>> Yes, I've tested it with target and custom_id links and, as you said, there
>> is no change in behavior. The entire URL is still pasted and no chance to
>> edit it is given to the user.
>
> Oops. Somehow some way things worked for me at some point when I was
> making the patch.
>
> See the updated version of the patch attached. It works on my side.
According to the further discussion, this patch does not resolve the
original problem. However, it improves similar cases with link
descriptions being set equal to the link values.
Applied.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4fc2c8dd89bfbe9f6ad7620c1b4d6def4114489b
The original problem is resolved in another applied patch from an
earlier discussion.
https://list.orgmode.org/e2c807a7-1924-6f08-9e63-4f70aee9d3b5@gmail.com
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
prev parent reply other threads:[~2022-09-13 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 17:44 Adding target and custom id links doesn't ask for description Carlos Pita
2022-08-02 18:58 ` Carlos Pita
2022-08-03 11:35 ` Max Nikulin
2022-08-10 5:39 ` [PATCH] " Ihor Radchenko
2022-08-10 12:30 ` Carlos Pita
2022-08-11 15:50 ` Max Nikulin
2022-08-12 19:18 ` Carlos Pita
2022-08-13 5:01 ` [PATCH v2] " Ihor Radchenko
2022-08-14 9:53 ` Max Nikulin
2022-09-11 13:18 ` Max Nikulin
2022-09-12 11:02 ` Ihor Radchenko
2022-09-12 16:05 ` Max Nikulin
2022-09-13 13:08 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkrjctg7.fsf@localhost \
--to=yantar92@gmail.com \
--cc=carlosjosepita@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).