emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description
Date: Sun, 14 Aug 2022 16:53:50 +0700	[thread overview]
Message-ID: <tdagnf$1012$1@ciao.gmane.io> (raw)
In-Reply-To: <8735e091pn.fsf@localhost>

On 13/08/2022 12:01, Ihor Radchenko wrote:
> See the updated version of the patch attached. It works on my side.
> 
> --- a/lisp/ol.el
> +++ b/lisp/ol.el
> @@ -1577,10 +1577,8 @@ (defun org-store-link (arg &optional interactive?)
>  		  t))))
>  	(setq link (plist-get org-store-link-plist :link))
>          ;; If store function actually set `:description' property, use
> -        ;; it, even if it is nil.  Otherwise, fallback to link value.
> -	(setq desc (if (plist-member org-store-link-plist :description)
> -                       (plist-get org-store-link-plist :description)
> -		     link)))
> +        ;; it, even if it is nil.  Otherwise, fallback to nil (ask user).
> +	(setq desc (plist-get org-store-link-plist :description)))

I can not say that I understand design of `org-store-link` and 
`org-insert-link' pair, but I suspect that you might try to fix the 
issue in a wrong place.

It seems the same :link and :description value were set for purpose, see 
`org-insert-link' code:

	    (dolist (l org-stored-links)
	      (when (equal link (cadr l))
		(setq link (car l))
		(setq auto-desc t)))

However I am puzzled by

     (unless auto-desc

I would say that namely the same :link and :description should cause 
query to default description and user prompt.

I may be wrong. Maybe the protocol of communication between these 
functions may be documented with more details.

next prev parent reply	other threads:[~2022-08-14  9:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 17:44 Adding target and custom id links doesn't ask for description Carlos Pita
2022-08-02 18:58 ` Carlos Pita
2022-08-03 11:35   ` Max Nikulin
2022-08-10  5:39 ` [PATCH] " Ihor Radchenko
2022-08-10 12:30   ` Carlos Pita
2022-08-11 15:50     ` Max Nikulin
2022-08-12 19:18       ` Carlos Pita
2022-08-13  5:01         ` [PATCH v2] " Ihor Radchenko
2022-08-14  9:53           ` Max Nikulin [this message]
2022-09-11 13:18             ` Max Nikulin
2022-09-12 11:02               ` Ihor Radchenko
2022-09-12 16:05                 ` Max Nikulin
2022-09-13 13:08           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='tdagnf$1012$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).