emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Re: Adding target and custom id links doesn't ask for description
Date: Thu, 11 Aug 2022 22:50:00 +0700	[thread overview]
Message-ID: <af2ff9f8-ad39-b6bb-97ee-955359d92958@gmail.com> (raw)
In-Reply-To: <CAELgYheiqXRT=3J54Qm53iKjrhWO61FBbZ+KiSq2m9vHK=V+OA@mail.gmail.com>

On 10/08/2022 19:30, Carlos Pita wrote:
>     I suggest to set description to nil and thus ask the user in such
>     scenario.
> I'm fine with that. Alternatively the default may be the target or 
> custom id (that is, the same that is in the link part), again letting 
> the user change it. Thanks!

Carlos, have you tried Ihor's patch? I like the intention, but I do not 
see any effect. If I read the code correctly, first chunk is for C-u 
C-u, second one for id, not CUSTOM_ID links. The latter works on the 
main branch: I am prompted to confirm heading title as description. So I 
am confused.

In my environment my patches:

Max Nikulin. Re: Bug: org-store-link uses CUSTOM_ID instead of target 
point. Sat, 6 Nov 2021 19:51:29 +0700. 

helps for #CUSTOM_ID and <<target>> links. Heading title is offered in 
the first case and empty description in the latter.

P.S. The reason why file name is originally stored is that the link may 
be inserted to another file. When link is inserted to the same document, 
only target part is transformed to strip file name, description remains 
as it was stored.

  reply	other threads:[~2022-08-11 15:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 17:44 Adding target and custom id links doesn't ask for description Carlos Pita
2022-08-02 18:58 ` Carlos Pita
2022-08-03 11:35   ` Max Nikulin
2022-08-10  5:39 ` [PATCH] " Ihor Radchenko
2022-08-10 12:30   ` Carlos Pita
2022-08-11 15:50     ` Max Nikulin [this message]
2022-08-12 19:18       ` Carlos Pita
2022-08-13  5:01         ` [PATCH v2] " Ihor Radchenko
2022-08-14  9:53           ` Max Nikulin
2022-09-11 13:18             ` Max Nikulin
2022-09-12 11:02               ` Ihor Radchenko
2022-09-12 16:05                 ` Max Nikulin
2022-09-13 13:08           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2ff9f8-ad39-b6bb-97ee-955359d92958@gmail.com \
    --to=manikulin@gmail.com \
    --cc=carlosjosepita@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).