emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Federico Beffa <beffa@ieee.org>
Cc: emacs-orgmode@gnu.org, Rasmus <rasmus@gmx.us>
Subject: Re: [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line
Date: Thu, 28 Aug 2014 12:10:51 +0200	[thread overview]
Message-ID: <878um8gc0k.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAKrPhPPtaSiGc8LBuLSwbcvnix5L1L6EWnwVcP00H2Ktiwafqw@mail.gmail.com> (Federico Beffa's message of "Sat, 16 Aug 2014 09:38:29 +0200")

Hello,

Federico Beffa <beffa@ieee.org> writes:

> In any case, I've updated my git repository (less than 24h ago) and
> recreated the patch. I've tested it and believe it is working. Why
> don't you give it a try. It's not such a disruptive change.

I looked at the patch. You are still applying it on maint, while the
function in /master/ branch is different. If you look at it, you will
see there are simple ways to achieve what you want (i.e no need for
3 helper functions and 80 additional locs).

Also, I think your implementation is still ill-defined. Consider the
following case:

 Paragraph with a very very ... long line \[some
 math\]

IIUC, M-q should fill the math snippet since it doesn't start nor end
lines. However, if I add text, e.g. additional "very" in the first line,
auto-filling will eventually move "\[some" to the next line, leading to

 Paragraph with a very very very very ... long line
 \[some
 math\]

which cannot be filled since, this time, "\[" starts a line and "\]"
ends one. This math snippet is at the same time fillable and
un-fillable. Schrödinger's snippet. IOW, you also need to prevent
"\[some" to be moved to a new line on its own.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2014-08-28 10:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10 13:13 [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line Federico Beffa
2014-08-11 13:06 ` Nicolas Goaziou
2014-08-11 18:27   ` Federico Beffa
2014-08-11 19:43     ` Rasmus
2014-08-11 20:44       ` Nicolas Goaziou
2014-08-16  7:50         ` Federico Beffa
2014-08-16  9:46           ` Nicolas Goaziou
2014-08-11 20:40     ` Nicolas Goaziou
2014-08-16  7:38       ` Federico Beffa
2014-08-28 10:10         ` Nicolas Goaziou [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-10 13:15 Federico Beffa
2014-08-07 13:56 Federico Beffa
2014-08-05 21:45 Federico Beffa
2014-08-09  8:00 ` Nicolas Goaziou
2014-08-09 10:20   ` Federico Beffa
2014-08-09 23:20     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878um8gc0k.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=beffa@ieee.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).