emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Noorul Islam K M <noorul@noorul.com>
To: Paul Sexton <psexton@xnet.co.nz>
Cc: emacs-orgmode@gnu.org
Subject: Re: Minor bug: org-agenda-holidays
Date: Wed, 22 Dec 2010 14:40:46 +0530	[thread overview]
Message-ID: <877hf2dvft.fsf@noorul.maa.corp.collab.net> (raw)
In-Reply-To: <4D11AE5C.6060504@xnet.co.nz> (Paul Sexton's message of "Wed, 22 Dec 2010 20:53:00 +1300")

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Paul Sexton <psexton@xnet.co.nz> writes:

> Yes.
> "Wrong type argument: commandp, list-calendar-holidays"
>
>

I think the following patch will fix the issue for you.

Log
[[[

Make org-agenda-holidays compatible with older versions of emacs.

* lisp/org-agenda.el (org-agenda-holidays): Make this function compatible
  with older versions of emacs.

]]]

Thanks and Regards
Noorul


[-- Attachment #2: add-backward-compatibility-for-list-calendar-holidays.txt --]
[-- Type: text/plain, Size: 596 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 19535b4..217c701 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7685,7 +7685,9 @@ the cursor position."
 (defun org-agenda-holidays ()
   "Display the holidays for the 3 months around the cursor date."
   (interactive)
-  (org-agenda-execute-calendar-command 'list-calendar-holidays))
+  (if (fboundp 'list-calendar-holidays)
+      (org-agenda-execute-calendar-command 'list-calendar-holidays)
+    (org-agenda-execute-calendar-command 'calendar-list-holidays)))
 
 (defvar calendar-longitude)
 (defvar calendar-latitude)

[-- Attachment #3: Type: text/plain, Size: 557 bytes --]


> On 22/12/2010 8:11 p.m., Noorul Islam K M wrote:
>> Paul Sexton<psexton@xnet.co.nz>  writes:
>>
>>> In org-agenda.el, the function org-agenda-holidays is coded as:
>>>
>>> (defun org-agenda-holidays ()
>>>    "Display the holidays for the 3 months around the cursor date."
>>>    (interactive)
>>>    (org-agenda-execute-calendar-command 'list-calendar-holidays))
>>>
>>> 'list-calendar-holidays' does not exist. It should be
>>> 'calendar-list-holidays'.
>>>
>> Did you  get any error when you executed this function?
>>
>> Thanks and Regards
>> Noorul

[-- Attachment #4: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  parent reply	other threads:[~2010-12-22  9:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21 20:21 Minor bug: org-agenda-holidays Paul Sexton
2010-12-21 20:35 ` Tassilo Horn
2010-12-22  7:11 ` Noorul Islam K M
     [not found]   ` <4D11AE5C.6060504@xnet.co.nz>
2010-12-22  9:10     ` Noorul Islam K M [this message]
2010-12-22 16:24       ` Nick Dokos
2010-12-22 19:22         ` Tassilo Horn
2010-12-22 19:54           ` Nick Dokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hf2dvft.fsf@noorul.maa.corp.collab.net \
    --to=noorul@noorul.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=psexton@xnet.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).