From: Nick Dokos <nicholas.dokos@hp.com>
To: Noorul Islam K M <noorul@noorul.com>
Cc: emacs-orgmode@gnu.org, nicholas.dokos@hp.com,
Paul Sexton <psexton@xnet.co.nz>
Subject: Re: Minor bug: org-agenda-holidays
Date: Wed, 22 Dec 2010 11:24:16 -0500 [thread overview]
Message-ID: <12593.1293035056@gamaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Noorul Islam K M <noorul@noorul.com> of "Wed, 22 Dec 2010 14:40:46 +0530." <877hf2dvft.fsf@noorul.maa.corp.collab.net>
Noorul Islam K M <noorul@noorul.com> wrote:
> Paul Sexton <psexton@xnet.co.nz> writes:
>
> > Yes.
> > "Wrong type argument: commandp, list-calendar-holidays"
> >
> >
>
> I think the following patch will fix the issue for you.
>
> Log
> [[[
>
> Make org-agenda-holidays compatible with older versions of emacs.
>
> * lisp/org-agenda.el (org-agenda-holidays): Make this function compatible
> with older versions of emacs.
>
> ]]]
>
I don't think the patch is necessary: as Tassilo points out,
list-calendar-holidays should exist in emacs versions before 23.1, it is
obsoleted in 23.1 and replaced by calendar-list-holidays, but remains as
an alias in versions 23.1 and after. I can confirm that in both
GNU Emacs 23.2.50.1 and GNU Emacs 24.0.50.1, the alias exists and in both cases
(commandp 'list-calendar-holidays)
returns t.
So it looks like a set-up problem at Paul's end and Tassilo's basic
question remains: what version of emacs are you (Paul) running?
If and when the alias goes away, and assuming org supports emacs versions
before 23.1 at that point, then a compatibility patch like Noorul's might
be necessary, but it's probably not a good idea to go for "premature
compatibility" so to speak :-)
Nick
next prev parent reply other threads:[~2010-12-22 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 20:21 Minor bug: org-agenda-holidays Paul Sexton
2010-12-21 20:35 ` Tassilo Horn
2010-12-22 7:11 ` Noorul Islam K M
[not found] ` <4D11AE5C.6060504@xnet.co.nz>
2010-12-22 9:10 ` Noorul Islam K M
2010-12-22 16:24 ` Nick Dokos [this message]
2010-12-22 19:22 ` Tassilo Horn
2010-12-22 19:54 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12593.1293035056@gamaville.dokosmarshall.org \
--to=nicholas.dokos@hp.com \
--cc=emacs-orgmode@gnu.org \
--cc=noorul@noorul.com \
--cc=psexton@xnet.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).