From: Nick Dokos <nicholas.dokos@hp.com>
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: Re: Minor bug: org-agenda-holidays
Date: Wed, 22 Dec 2010 14:54:41 -0500 [thread overview]
Message-ID: <8202.1293047681@gamaville.americas.hpqcorp.net> (raw)
In-Reply-To: Message from Tassilo Horn <tassilo@member.fsf.org> of "Wed, 22 Dec 2010 20:22:53 +0100." <87r5d9ipde.fsf@member.fsf.org>
Tassilo Horn <tassilo@member.fsf.org> wrote:
> Nick Dokos <nicholas.dokos@hp.com> writes:
>
> Hi Nick,
>
> > I don't think the patch is necessary: as Tassilo points out,
> > list-calendar-holidays should exist in emacs versions before 23.1, it
> > is obsoleted in 23.1 and replaced by calendar-list-holidays, but
> > remains as an alias in versions 23.1 and after. I can confirm that in
> > both GNU Emacs 23.2.50.1 and GNU Emacs 24.0.50.1, the alias exists and
> > in both cases
> >
> > (commandp 'list-calendar-holidays)
> >
> > returns t.
>
> I've just fired up emacs 23.1 on some other machine, and there is really
> only `calendar-list-holidays'.
>
> Hm, no, not true. But `calendar-list-holidays' is directly visible to
> C-h f cause it's autoloaded whereas `list-calendar-holidays' is only
> there after (require 'holidays). With newer emacsen, both are visible
> directly, probably because `define-obsolete-function-alias'.
>
Ah, thanks, that clears up things. I did some more spelunking on
emacs-22.3: only list-calendar-holidays exists there, so they seem to
have rationalized the name in 23.1 but didn't quite get the
compatibility right until 23.2 (or a later 23.1 at least, one after
Paul's version).
So, for Paul, the fix seems to be to
(require 'holidays)
in his .emacs somewhere, possibly before loading org-mode.
For org-mode, probably the best thing to do is to change
list-calendar-holidays to calendar-list-holidays as soon as support for
emacs-22.3 is dropped (except that there is still older - and current -
xemacsen to check of course). The joys of backward compatibility...
Nick
prev parent reply other threads:[~2010-12-22 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 20:21 Minor bug: org-agenda-holidays Paul Sexton
2010-12-21 20:35 ` Tassilo Horn
2010-12-22 7:11 ` Noorul Islam K M
[not found] ` <4D11AE5C.6060504@xnet.co.nz>
2010-12-22 9:10 ` Noorul Islam K M
2010-12-22 16:24 ` Nick Dokos
2010-12-22 19:22 ` Tassilo Horn
2010-12-22 19:54 ` Nick Dokos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8202.1293047681@gamaville.americas.hpqcorp.net \
--to=nicholas.dokos@hp.com \
--cc=emacs-orgmode@gnu.org \
--cc=tassilo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).