From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Re: Minor bug: org-agenda-holidays Date: Wed, 22 Dec 2010 14:54:41 -0500 Message-ID: <8202.1293047681@gamaville.americas.hpqcorp.net> References: <87fwtqe0y1.fsf@noorul.maa.corp.collab.net> <4D11AE5C.6060504@xnet.co.nz> <877hf2dvft.fsf@noorul.maa.corp.collab.net> <12593.1293035056@gamaville.dokosmarshall.org> <87r5d9ipde.fsf@member.fsf.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from [140.186.70.92] (port=46621 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVUls-0003CC-5p for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 14:54:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVUlp-0003Nj-EU for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 14:54:47 -0500 Received: from g5t0008.atlanta.hp.com ([15.192.0.45]:39414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVUlp-0003NE-Au for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 14:54:45 -0500 In-Reply-To: Message from Tassilo Horn of "Wed, 22 Dec 2010 20:22:53 +0100." <87r5d9ipde.fsf@member.fsf.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Tassilo Horn Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org Tassilo Horn wrote: > Nick Dokos writes: > > Hi Nick, > > > I don't think the patch is necessary: as Tassilo points out, > > list-calendar-holidays should exist in emacs versions before 23.1, it > > is obsoleted in 23.1 and replaced by calendar-list-holidays, but > > remains as an alias in versions 23.1 and after. I can confirm that in > > both GNU Emacs 23.2.50.1 and GNU Emacs 24.0.50.1, the alias exists and > > in both cases > > > > (commandp 'list-calendar-holidays) > > > > returns t. > > I've just fired up emacs 23.1 on some other machine, and there is really > only `calendar-list-holidays'. > > Hm, no, not true. But `calendar-list-holidays' is directly visible to > C-h f cause it's autoloaded whereas `list-calendar-holidays' is only > there after (require 'holidays). With newer emacsen, both are visible > directly, probably because `define-obsolete-function-alias'. > Ah, thanks, that clears up things. I did some more spelunking on emacs-22.3: only list-calendar-holidays exists there, so they seem to have rationalized the name in 23.1 but didn't quite get the compatibility right until 23.2 (or a later 23.1 at least, one after Paul's version). So, for Paul, the fix seems to be to (require 'holidays) in his .emacs somewhere, possibly before loading org-mode. For org-mode, probably the best thing to do is to change list-calendar-holidays to calendar-list-holidays as soon as support for emacs-22.3 is dropped (except that there is still older - and current - xemacsen to check of course). The joys of backward compatibility... Nick