From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch, koma-letter] Change of subject behavior
Date: Wed, 18 Mar 2015 12:41:17 +0100 [thread overview]
Message-ID: <877fue1qjm.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <877fufdwf0.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 18 Mar 2015 00:41:23 +0100")
Rasmus <rasmus@gmx.us> writes:
>>> + (:with-headline-opening nil nil
>>> org-koma-letter-headline-is-opening-maybe)
>>
>> I don't think this line is required.
>
> It feels more consistent to provide the check through the definition, but
> I'm not willing to pick a fight over this so it's back to just checking
> the variable.
Of course, you're right. It is way better to add it as an option, since
you can override variable value during publishing. You can irrevocably
ignore my comment.
> I have only tested the patch briefly as I need to actually produce a
> letter. But for the letter I'm writing export works fine.
You sent a wrong patch.
Regards,
next prev parent reply other threads:[~2015-03-18 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 17:37 [patch, koma-letter] Change of subject behavior Rasmus
2015-03-17 21:00 ` Nicolas Goaziou
2015-03-17 22:48 ` Rasmus
2015-03-17 23:08 ` Nicolas Goaziou
2015-03-17 23:41 ` Rasmus
2015-03-18 11:41 ` Nicolas Goaziou [this message]
2015-03-18 12:39 ` Rasmus
2015-03-18 20:27 ` Nicolas Goaziou
2015-03-19 11:35 ` Rasmus
2015-03-19 23:15 ` Nicolas Goaziou
2015-03-20 20:22 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fue1qjm.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).