From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch, koma-letter] Change of subject behavior
Date: Fri, 20 Mar 2015 00:15:36 +0100 [thread overview]
Message-ID: <87sid0y3xj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87twxh9q3l.fsf@gmx.us> (rasmus@gmx.us's message of "Thu, 19 Mar 2015 12:35:58 +0100")
Rasmus <rasmus@gmx.us> writes:
> +(defun org-koma-letter--special-tag (headline info)
> + "Non-nil if HEADLINE is a special headline.
> +INFO is a plist holding contextual information. Returns first
^^^
"Return", per (info "(elisp)Documentation Tips")
> +special tag headline."
> + (let ((special-tags (plist-get info :special-tags)))
> + (catch 'exit
> + (dolist (tag (org-export-get-tags headline info))
> + (funcall (lambda (tag) (when tag (throw 'exit tag)))
> + (assoc-string tag special-tags))))))
This is the usual definition for (let ...), i.e., you just wrote
(let ((tag (assoc-string tag special-tags)))
(when tag (throw 'exit tag)))
Please just use `let', as it is much more readable.
AFAIC, you can push the patches, when the above is fixed. Thank you.
Regards,
next prev parent reply other threads:[~2015-03-19 23:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 17:37 [patch, koma-letter] Change of subject behavior Rasmus
2015-03-17 21:00 ` Nicolas Goaziou
2015-03-17 22:48 ` Rasmus
2015-03-17 23:08 ` Nicolas Goaziou
2015-03-17 23:41 ` Rasmus
2015-03-18 11:41 ` Nicolas Goaziou
2015-03-18 12:39 ` Rasmus
2015-03-18 20:27 ` Nicolas Goaziou
2015-03-19 11:35 ` Rasmus
2015-03-19 23:15 ` Nicolas Goaziou [this message]
2015-03-20 20:22 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sid0y3xj.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).