From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch, koma-letter] Change of subject behavior Date: Fri, 20 Mar 2015 00:15:36 +0100 Message-ID: <87sid0y3xj.fsf@nicolasgoaziou.fr> References: <87d247h6eo.fsf@gmx.us> <87wq2f1gqz.fsf@nicolasgoaziou.fr> <87mw3bdyv4.fsf@gmx.us> <87bnjr1au0.fsf@nicolasgoaziou.fr> <877fufdwf0.fsf@gmx.us> <877fue1qjm.fsf@nicolasgoaziou.fr> <878ueuv5rm.fsf@gmx.us> <873852125y.fsf@nicolasgoaziou.fr> <87twxh9q3l.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYje1-0002BL-6b for emacs-orgmode@gnu.org; Thu, 19 Mar 2015 19:14:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYjdv-00069s-4Y for emacs-orgmode@gnu.org; Thu, 19 Mar 2015 19:14:29 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:c:538::197]:59642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYjdu-00069g-US for emacs-orgmode@gnu.org; Thu, 19 Mar 2015 19:14:23 -0400 In-Reply-To: <87twxh9q3l.fsf@gmx.us> (rasmus@gmx.us's message of "Thu, 19 Mar 2015 12:35:58 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > +(defun org-koma-letter--special-tag (headline info) > + "Non-nil if HEADLINE is a special headline. > +INFO is a plist holding contextual information. Returns first ^^^ "Return", per (info "(elisp)Documentation Tips") > +special tag headline." > + (let ((special-tags (plist-get info :special-tags))) > + (catch 'exit > + (dolist (tag (org-export-get-tags headline info)) > + (funcall (lambda (tag) (when tag (throw 'exit tag))) > + (assoc-string tag special-tags)))))) This is the usual definition for (let ...), i.e., you just wrote (let ((tag (assoc-string tag special-tags))) (when tag (throw 'exit tag))) Please just use `let', as it is much more readable. AFAIC, you can push the patches, when the above is fixed. Thank you. Regards,