From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch, koma-letter] Change of subject behavior
Date: Wed, 18 Mar 2015 21:27:53 +0100 [thread overview]
Message-ID: <873852125y.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878ueuv5rm.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 18 Mar 2015 13:39:41 +0100")
Rasmus <rasmus@gmx.us> writes:
> - (cdr (assoc (org-koma-letter--get-value key)
> - org-koma-letter-special-contents)))
> + (cdr (assoc-string (org-koma-letter--get-value key)
> + org-koma-letter-special-contents)))
AFAIU, this is a bugfix, so it should go in a separate commit.
> + (let ((special-tag (car (org-koma-letter--special-headline headline info))))
> + (if special-tag
> + (progn (push (cons special-tag contents) org-koma-letter-special-contents)
> + "")
> + contents)))
Nitpick:
(if (not special-tag) contents
(push ...)
"")
In this case, I suggest to change `org-koma-letter--special-headline'
into `org-koma-letter--special-tag', where the latter explicitly returns
special tag associated to the current headline, or nil (this skips the
`car' part).
> +(defun org-koma-letter--special-headline (headline info)
> + "Nonnil if HEADLINE is a special headline."
> + (let ((special-tags (plist-get info :special-tags)))
> + (mapcar (lambda (tag) (assoc-string tag special-tags))
> + (org-export-get-tags headline info))))
"Non-nil"
Also, the docstring should document INFO. Moreover, it isn't really
a predicate anymore, since you're using the value returned. Thus, that
value should be explained.
Eventually, since you're only interested in the first special tag
encountered, it may be cleaner to exit early, e.g.,
(defun org-koma-letter--special-tag (headline info)
"Return special tag associated to HEADLINE, as a symbol, or nil.
INFO is the current state of the export process, as a plist."
(let ((special-tags (plist-get info :special-tags)))
(catch 'exit
(dolist (tag (org-export-get-tags headline info))
(let ((special-match (assoc-string tag special-tags)))
(when special-match (throw 'exit (car special-match))))))))
> + (format "\\opening{%s}\n\n"
> + (org-export-data
> + (or (org-string-nw-p (plist-get info :opening))
> + (when (plist-get info :with-headline-opening)
> + (org-element-map (org-element-parse-buffer) 'headline
^^^^^^^^^^^^^^^^^^^^^^^^^
(plist-get info :parse-tree)
Regards,
next prev parent reply other threads:[~2015-03-18 20:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 17:37 [patch, koma-letter] Change of subject behavior Rasmus
2015-03-17 21:00 ` Nicolas Goaziou
2015-03-17 22:48 ` Rasmus
2015-03-17 23:08 ` Nicolas Goaziou
2015-03-17 23:41 ` Rasmus
2015-03-18 11:41 ` Nicolas Goaziou
2015-03-18 12:39 ` Rasmus
2015-03-18 20:27 ` Nicolas Goaziou [this message]
2015-03-19 11:35 ` Rasmus
2015-03-19 23:15 ` Nicolas Goaziou
2015-03-20 20:22 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873852125y.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).