* [PATCH] org-drill.el: Fix void function error
@ 2019-03-16 11:38 alexander.haeckel
2019-04-07 6:59 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: alexander.haeckel @ 2019-03-16 11:38 UTC (permalink / raw)
To: emacs-orgmode
* org-drill.el (org-drill--compute-cloze-keywords, org-drill-cloze-regexp) Use
real function name cl-copy-list instead of alias copy-list, because of void
function error at org startup in emacs 26.1 for org-plus-contrib package.
---
contrib/lisp/org-drill.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
index 1c11515..36b5bb4 100644
--- a/contrib/lisp/org-drill.el
+++ b/contrib/lisp/org-drill.el
@@ -241,9 +241,9 @@ the hidden cloze during a test.")
(defun org-drill--compute-cloze-keywords ()
(list (list (org-drill--compute-cloze-regexp)
- (copy-list '(1 'org-drill-visible-cloze-face nil))
- (copy-list '(2 'org-drill-visible-cloze-hint-face t))
- (copy-list '(3 'org-drill-visible-cloze-face nil))
+ (cl-copy-list '(1 'org-drill-visible-cloze-face nil))
+ (cl-copy-list '(2 'org-drill-visible-cloze-hint-face t))
+ (cl-copy-list '(3 'org-drill-visible-cloze-face nil))
)))
(defvar-local org-drill-cloze-regexp
@@ -1011,7 +1011,7 @@ in the matrix."
(learn-str
(let ((learn-data (or (and learn-str
(read learn-str))
- (copy-list initial-repetition-state))))
+ (cl-copy-list initial-repetition-state))))
(list (nth 0 learn-data) ; last interval
(nth 1 learn-data) ; repetitions
(org-drill-entry-failure-count)
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] org-drill.el: Fix void function error
2019-03-16 11:38 [PATCH] org-drill.el: Fix void function error alexander.haeckel
@ 2019-04-07 6:59 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2019-04-07 6:59 UTC (permalink / raw)
To: alexander.haeckel; +Cc: emacs-orgmode
Hello,
alexander.haeckel@web.de writes:
> * org-drill.el (org-drill--compute-cloze-keywords, org-drill-cloze-regexp) Use
> real function name cl-copy-list instead of alias copy-list, because of void
> function error at org startup in emacs 26.1 for org-plus-contrib package.
> ---
> contrib/lisp/org-drill.el | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
> index 1c11515..36b5bb4 100644
> --- a/contrib/lisp/org-drill.el
> +++ b/contrib/lisp/org-drill.el
> @@ -241,9 +241,9 @@ the hidden cloze during a test.")
>
> (defun org-drill--compute-cloze-keywords ()
> (list (list (org-drill--compute-cloze-regexp)
> - (copy-list '(1 'org-drill-visible-cloze-face nil))
> - (copy-list '(2 'org-drill-visible-cloze-hint-face t))
> - (copy-list '(3 'org-drill-visible-cloze-face nil))
> + (cl-copy-list '(1 'org-drill-visible-cloze-face nil))
> + (cl-copy-list '(2 'org-drill-visible-cloze-hint-face t))
> + (cl-copy-list '(3 'org-drill-visible-cloze-face nil))
> )))
>
> (defvar-local org-drill-cloze-regexp
> @@ -1011,7 +1011,7 @@ in the matrix."
> (learn-str
> (let ((learn-data (or (and learn-str
> (read learn-str))
> - (copy-list initial-repetition-state))))
> + (cl-copy-list initial-repetition-state))))
> (list (nth 0 learn-data) ; last interval
> (nth 1 learn-data) ; repetitions
> (org-drill-entry-failure-count)
Thank you. I ended up applying a slightly different patch, though.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-07 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-16 11:38 [PATCH] org-drill.el: Fix void function error alexander.haeckel
2019-04-07 6:59 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).