emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: alexander.haeckel@web.de
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-drill.el: Fix void function error
Date: Sun, 07 Apr 2019 08:59:44 +0200	[thread overview]
Message-ID: <874l7a7127.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <trinity-eb804a0c-ca3b-41e9-ba30-301cc570bdb0-1552736301006@3c-app-webde-bap05> (alexander haeckel's message of "Sat, 16 Mar 2019 12:38:21 +0100")

Hello,

alexander.haeckel@web.de writes:

> * org-drill.el (org-drill--compute-cloze-keywords, org-drill-cloze-regexp) Use
>   real function name cl-copy-list instead of alias copy-list, because of void
>   function error at org startup in emacs 26.1 for org-plus-contrib package.
> ---
>  contrib/lisp/org-drill.el | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
> index 1c11515..36b5bb4 100644
> --- a/contrib/lisp/org-drill.el
> +++ b/contrib/lisp/org-drill.el
> @@ -241,9 +241,9 @@ the hidden cloze during a test.")
>
>  (defun org-drill--compute-cloze-keywords ()
>    (list (list (org-drill--compute-cloze-regexp)
> -              (copy-list '(1 'org-drill-visible-cloze-face nil))
> -              (copy-list '(2 'org-drill-visible-cloze-hint-face t))
> -              (copy-list '(3 'org-drill-visible-cloze-face nil))
> +              (cl-copy-list '(1 'org-drill-visible-cloze-face nil))
> +              (cl-copy-list '(2 'org-drill-visible-cloze-hint-face t))
> +              (cl-copy-list '(3 'org-drill-visible-cloze-face nil))
>                )))
>
>  (defvar-local org-drill-cloze-regexp
> @@ -1011,7 +1011,7 @@ in the matrix."
>       (learn-str
>        (let ((learn-data (or (and learn-str
>                                   (read learn-str))
> -                            (copy-list initial-repetition-state))))
> +                            (cl-copy-list initial-repetition-state))))
>          (list (nth 0 learn-data)        ; last interval
>                (nth 1 learn-data)        ; repetitions
>                (org-drill-entry-failure-count)

Thank you. I ended up applying a slightly different patch, though.

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2019-04-07  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 11:38 [PATCH] org-drill.el: Fix void function error alexander.haeckel
2019-04-07  6:59 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l7a7127.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=alexander.haeckel@web.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).