From: stardiviner <numbchild@gmail.com>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add NO-STATS switch to org-get-heading
Date: Sun, 15 Mar 2020 08:24:41 +0800 [thread overview]
Message-ID: <8736aa8nxy.fsf@gmail.com> (raw)
In-Reply-To: <87k13o143q.fsf@alphapapa.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Adam Porter <adam@alphapapa.net> writes:
> Please don't add more arguments to org-get-heading. It used to have 2,
> then it had 4, and now you want to add a 5th. Every time the function's
> signature changes, it breaks code in third-party packages and user code
> in random places, which requires the addition of messy compatibility
> code and intermediate functions that do nothing but wrap org-get-heading
> with a certain number of arguments.
>
> It would be much preferable to make a new function that uses keyword
> arguments so the addition of more arguments won't affect existing code.
> Maybe it could be called org-entry-heading.
I agree, this statistic cookie is not very necessary for getting headline.
This totally can be done in tools by author self.
- --
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----
iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5tdckUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsPq7wgAtr+HkiPHuTmjGsrZaYJkAcTVjwHH
cg+drGKhZmGhADYeR5Sb2fmf8Vghn6DavhxjQrryIAFw5lic9n0DuqgzFe0TP/+Z
SCd8sixjSGqlmjouTcqXgo8QXqPbTJNQyYUwqLYwawyh44LW4AvMFo5UCihr+Mg6
PCDilLMlAV6w0ondqOwaMgbSooU1oZ11jVO5bacgJZzqTeLThMtn0+Cv5b3Lx0lH
j5jnWnJ2HSqYyI96xktWrDU+Wyy2mhKKrHrALl8HNiih3QemSuEJonYt/KsCA3JJ
SzATd0GNGGdg5v5z7k206yOgC+O6ViaeNb070i9I4wRdPDp0FWqHguCMIQ==
=twGf
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2020-03-15 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:11 [PATCH] Add NO-STATS switch to org-get-heading Brice Waegeneire
2020-03-13 17:22 ` Nicolas Goaziou
2020-03-13 17:37 ` Nicolas Goaziou
2020-03-13 17:41 ` Brice Waegeneire
2020-03-13 18:50 ` Adam Porter
2020-03-15 0:24 ` stardiviner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736aa8nxy.fsf@gmail.com \
--to=numbchild@gmail.com \
--cc=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).