emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Brice Waegeneire <brice@waegenei.re>
To: Brice Waegeneire <brice@waegenei.re>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add NO-STATS switch to org-get-heading
Date: Fri, 13 Mar 2020 17:41:44 +0000	[thread overview]
Message-ID: <f932e0771f69f0c1bafacf5aa54549c8@waegenei.re> (raw)
In-Reply-To: <87sgic890t.fsf@nicolasgoaziou.fr>

Hello Nicolas,

On 2020-03-13 17:22, Nicolas Goaziou wrote:
>> * lisp/org-element.el (org-element-context): Handle headlines only
>> containing a statistics cookie.
>> * lisp/org.el (test-org/get-heading): Add regex capture group 6 for
>> statistics cookie.
>> (org-get-heading): Add NO-STATS argument, if
>> non-nil, will not return the statistics cookie.
>> * testing/lisp/test-org.el (test-org/get-heading): Add 3 tests using 
>> the
>> NO-STATS argument.
> 
> This assumes statistics cookie is always located at the end of the
> title, before the tags. This is not required by the syntax.
> 
> Syntax can evolve, but it could introduce many backward
> incompatibilities, so it must be discussed first.

I wasn't sure about this. I don't remember ever seeing somebody putting 
the
statistics cookie before the title but org-complex-heading-regexp-format
does support two position for the statistics cookie. Would adding 
support
for the two locations to this patch make the review process faster?

I was just looking for a way to get a heading title without any 
metadata.

Cheers.

  parent reply	other threads:[~2020-03-13 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 15:11 [PATCH] Add NO-STATS switch to org-get-heading Brice Waegeneire
2020-03-13 17:22 ` Nicolas Goaziou
2020-03-13 17:37   ` Nicolas Goaziou
2020-03-13 17:41   ` Brice Waegeneire [this message]
2020-03-13 18:50 ` Adam Porter
2020-03-15  0:24   ` stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f932e0771f69f0c1bafacf5aa54549c8@waegenei.re \
    --to=brice@waegenei.re \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).