From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] Add NO-STATS switch to org-get-heading Date: Sun, 15 Mar 2020 08:24:41 +0800 Message-ID: <8736aa8nxy.fsf@gmail.com> References: <20200313151145.29469-1-brice@waegenei.re> <87k13o143q.fsf@alphapapa.net> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:57036) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDH5K-00011V-Jq for emacs-orgmode@gnu.org; Sat, 14 Mar 2020 20:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDH5J-0007pM-9X for emacs-orgmode@gnu.org; Sat, 14 Mar 2020 20:24:54 -0400 Received: from [183.249.133.91] (port=8141 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jDH5I-0007Yl-PZ for emacs-orgmode@gnu.org; Sat, 14 Mar 2020 20:24:53 -0400 In-reply-to: <87k13o143q.fsf@alphapapa.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Adam Porter Cc: emacs-orgmode@gnu.org =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Adam Porter writes: > Please don't add more arguments to org-get-heading. It used to have 2, > then it had 4, and now you want to add a 5th. Every time the function's > signature changes, it breaks code in third-party packages and user code > in random places, which requires the addition of messy compatibility > code and intermediate functions that do nothing but wrap org-get-heading > with a certain number of arguments. > > It would be much preferable to make a new function that uses keyword > arguments so the addition of more arguments won't affect existing code. > Maybe it could be called org-entry-heading. I agree, this statistic cookie is not very necessary for getting headline. This totally can be done in tools by author self. =2D --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5tdckUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsPq7wgAtr+HkiPHuTmjGsrZaYJkAcTVjwHH cg+drGKhZmGhADYeR5Sb2fmf8Vghn6DavhxjQrryIAFw5lic9n0DuqgzFe0TP/+Z SCd8sixjSGqlmjouTcqXgo8QXqPbTJNQyYUwqLYwawyh44LW4AvMFo5UCihr+Mg6 PCDilLMlAV6w0ondqOwaMgbSooU1oZ11jVO5bacgJZzqTeLThMtn0+Cv5b3Lx0lH j5jnWnJ2HSqYyI96xktWrDU+Wyy2mhKKrHrALl8HNiih3QemSuEJonYt/KsCA3JJ SzATd0GNGGdg5v5z7k206yOgC+O6ViaeNb070i9I4wRdPDp0FWqHguCMIQ=3D=3D =3DtwGf =2D----END PGP SIGNATURE-----