emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jack Kamm <jackkamm@gmail.com>
To: numbchild@gmail.com, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell
Date: Tue, 18 Feb 2020 09:18:33 -0800	[thread overview]
Message-ID: <871rqrak5y.fsf@gmail.com> (raw)
In-Reply-To: <874kvnako5.fsf@gmail.com>

Hi stardiviner,

Sorry for the noise, I have some additional comments below:

When I run "make compile", I get the following message:

In org-babel-python-initiate-session-by-key:
ob-python.el:211:12:Warning: py-shell called with 9 arguments, but accepts
    only 0-1

I think this is because the "(declare-function py-shell)" no longer
matches the signature of the upstream py-shell function you're using.

Also, I now see that the commit does have a changelog entry, but not a
commit message. Unless it is standard to take the subject line as the
commit message? I am still a little new to merging patches from email,
and might not have all the proper tooling setup for it.

When you update the patch, please mention that this is specifically for
python-mode.el in the commit message and changelog entry.

  reply	other threads:[~2020-02-18 17:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 12:55 [PATCH] Fix ob-python.el initiate session error with py-shell stardiviner
2020-02-18 13:07 ` Bastien
2020-02-18 17:07 ` Jack Kamm
2020-02-18 17:18   ` Jack Kamm [this message]
2020-02-18 20:23     ` Bastien
2020-02-19  7:38     ` numbchild
2020-02-19 15:51       ` Jack Kamm
2020-02-19 16:03         ` Bastien
2020-02-20  5:45         ` stardiviner
2020-02-20 16:26           ` Andreas Röhler
2020-02-20 17:46             ` Bastien
2020-02-20 18:51               ` Jack Kamm
2020-02-20 19:08                 ` Bastien
2020-02-22 14:28               ` stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rqrak5y.fsf@gmail.com \
    --to=jackkamm@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).