From: Jack Kamm <jackkamm@gmail.com>
To: "numbchild@gmail.com" <numbchild@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell
Date: Wed, 19 Feb 2020 07:51:24 -0800 [thread overview]
Message-ID: <87wo8ik22r.fsf@gmail.com> (raw)
In-Reply-To: <CAL1eYu+2MhYJq3fOduU1miefTiXtV+v0vtsJ=BobastLNnzyNg@mail.gmail.com>
Hi stardiviner,
"numbchild@gmail.com" <numbchild@gmail.com> writes:
> Yes, Jack, as Bastien said, you can format my commit, because my home
> network is broken, I'm using Mobile Phone's 4G network to get online. Can't
> get update immediately.
OK, I've edited the commit message of your patch, and I also fixed the
compilation warning by updating the signature of "(declare-function
py-shell)".
Commit has now been pushed to master :)
> And thanks for tips about `python-mode' is deprecated. I didn't know that.
> I will migrate to `python.el'.
Since python.el is built-in to Emacs, I think that things should
continue to work for python-mode.el users, even if we entirely switch
over to only using python.el.
The only thing I'm not sure about, is whether the equivalent of
"python-shell-send-region" in python-mode.el will work with shells
started by python.el. If not, this could probably be addressed with a
patch to python-mode.el.
You could test this by explicitly setting `org-babel-python-mode' to
`python' (it is probably set to `python-mode' on your system, which is
the default when python-mode.el is detected).
I'll add a TODO for myself to explicitly mark python-mode-related
variables as deprecated. I'm also planning a major update to the Worg
documentation of ob-python when 9.4 comes out, and will mention the
deprecation there as well.
next prev parent reply other threads:[~2020-02-19 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:55 [PATCH] Fix ob-python.el initiate session error with py-shell stardiviner
2020-02-18 13:07 ` Bastien
2020-02-18 17:07 ` Jack Kamm
2020-02-18 17:18 ` Jack Kamm
2020-02-18 20:23 ` Bastien
2020-02-19 7:38 ` numbchild
2020-02-19 15:51 ` Jack Kamm [this message]
2020-02-19 16:03 ` Bastien
2020-02-20 5:45 ` stardiviner
2020-02-20 16:26 ` Andreas Röhler
2020-02-20 17:46 ` Bastien
2020-02-20 18:51 ` Jack Kamm
2020-02-20 19:08 ` Bastien
2020-02-22 14:28 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo8ik22r.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).