From: "numbchild@gmail.com" <numbchild@gmail.com>
To: Jack Kamm <jackkamm@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell
Date: Wed, 19 Feb 2020 15:38:46 +0800 [thread overview]
Message-ID: <CAL1eYu+2MhYJq3fOduU1miefTiXtV+v0vtsJ=BobastLNnzyNg@mail.gmail.com> (raw)
In-Reply-To: <871rqrak5y.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
Yes, Jack, as Bastien said, you can format my commit, because my home
network is broken, I'm using Mobile Phone's 4G network to get online. Can't
get update immediately.
And thanks for tips about `python-mode' is deprecated. I didn't know that.
I will migrate to `python.el'.
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Wed, Feb 19, 2020 at 1:18 AM Jack Kamm <jackkamm@gmail.com> wrote:
> Hi stardiviner,
>
> Sorry for the noise, I have some additional comments below:
>
> When I run "make compile", I get the following message:
>
> In org-babel-python-initiate-session-by-key:
> ob-python.el:211:12:Warning: py-shell called with 9 arguments, but accepts
> only 0-1
>
> I think this is because the "(declare-function py-shell)" no longer
> matches the signature of the upstream py-shell function you're using.
>
> Also, I now see that the commit does have a changelog entry, but not a
> commit message. Unless it is standard to take the subject line as the
> commit message? I am still a little new to merging patches from email,
> and might not have all the proper tooling setup for it.
>
> When you update the patch, please mention that this is specifically for
> python-mode.el in the commit message and changelog entry.
>
[-- Attachment #2: Type: text/html, Size: 2336 bytes --]
next prev parent reply other threads:[~2020-02-19 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:55 [PATCH] Fix ob-python.el initiate session error with py-shell stardiviner
2020-02-18 13:07 ` Bastien
2020-02-18 17:07 ` Jack Kamm
2020-02-18 17:18 ` Jack Kamm
2020-02-18 20:23 ` Bastien
2020-02-19 7:38 ` numbchild [this message]
2020-02-19 15:51 ` Jack Kamm
2020-02-19 16:03 ` Bastien
2020-02-20 5:45 ` stardiviner
2020-02-20 16:26 ` Andreas Röhler
2020-02-20 17:46 ` Bastien
2020-02-20 18:51 ` Jack Kamm
2020-02-20 19:08 ` Bastien
2020-02-22 14:28 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1eYu+2MhYJq3fOduU1miefTiXtV+v0vtsJ=BobastLNnzyNg@mail.gmail.com' \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=jackkamm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).