Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[B Goodr]

[-- Attachment #1: Type: text/plain, Size: 7928 bytes --]

Hi,

Still loving Org mode!!  Keep up the good work.

Here is a bug, though:

Steps to reproduce:

Store the following into some .org file (in between the "cut-here" lines):

---cut-here---cut-here---cut-here---cut-here---cut-here---cut-here---
* TODO aaa bbb ccc

** TODO aaa bbb ccc

delete-this-line-to-see-the-problem
---cut-here---cut-here---cut-here---cut-here---cut-here---cut-here---

Move point at first asterisk (beginning of buffer).

Type TAB key (bound to org-cycle) multiple times and notice it cycles
the headings through the various levels of exposure.

Now go to the end of the buffer, and delete the one line there
containing "delete-this-line-to-see-the-problem", but retain the two
empty lines at the end.

Repeat the above steps with the TAB key at the top of the buffer, and
notice it stops working.

On the mailing list, I see some recent changes that might or might not
have broken this. I've not upgraded Org mode in a while:

https://lists.gnu.org/archive/html/emacs-orgmode/2020-09/msg00520.html

Thanks!
-bgoodr



Emacs  : GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.14)
 of 2020-03-26, modified by Debian
Package: Org mode version 9.4 (9.4-elpaplus @
/home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-after-execute-hook '(bg-org-babel-after-execute-hook)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-export-with-sub-superscripts nil
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-refile-targets '((nil :maxlevel . 9) (org-agenda-files :maxlevel . 9))
 org-html-format-inlinetask-function
'org-html-format-inlinetask-default-function
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-agenda-files "/home/brentg/Plans/Home/org-agenda-files-list-file.txt"
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-plantuml-jar-path "/home/brentg/plantuml/plantuml.jar"
 org-startup-folded nil
 org-id-link-to-org-use-id t
 org-mode-hook '(org-tempo-setup org-clock-load bg-org-mode-hook #[0
"\301\211 \207" [imenu-create-index-function org-imenu-get-tree] 2]
#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook
org-show-all append local] 5]
#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook
org-babel-show-result-all append local] 5] org-babel-result-hide-spec
org-babel-hide-all-hashes org-eldoc-load)
 org-clock-persist t
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'bg-org-confirm-elisp-link
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-adapt-indentation nil
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-file-apps '((auto-mode . emacs) (directory . emacs) ("\\.mm\\'" .
default) ("\\.x?html?\\'" lambda (file link) (browse-url-of-file
(expand-file-name file))) ("\\.pdf\\'" . default))
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
 org-babel-load-languages '((emacs-lisp . t) (python . t) (shell . t)
(sqlite . t) (dot . t) (plantuml . t))
 org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME CONTENTS
WIDTH)"]
 org-agenda-loop-over-headlines-in-active-region nil
 org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php" . php)
("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" .
latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist)
     ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg)
("screen" . shell-script) ("shell" . sh) ("sqlite" . sql))
 org-occur-hook '(org-first-headline-recenter)
 org-html-head-include-default-style nil
 org-html-htmlize-output-type 'css
 org-export-headline-levels 100
 org-edit-src-auto-save-idle-delay 5
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
 org-todo-keywords '((sequence "TODO(t)" "|" "DONE(d)" "SHELVED(s)"
"DELEGATED(e)"))
 org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
 org-clock-persist-file "/home/brentg/Plans/Home/org-clock-save.el"
 org-odt-format-inlinetask-function
'org-odt-format-inlinetask-default-function
 org-babel-tangle-lang-exts '(("python" . "py") ("emacs-lisp" . "el")
("elisp" . "el"))
 org-return-follows-link t
 org-refile-use-outline-path 'file
 org-clock-in-hook '(bg-org-clock-in-hook)
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-id-locations-file "/home/brentg/Plans/Home/.org-id-locations"
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow
org-eww-open :store org-eww-store-link)
      ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe"
:follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link :export
org-irc-export) ("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
      ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview"
:follow org-docview-open :export org-docview-export :store
org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
org-bbdb-complete-link :store org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
("shell" :follow org-link--open-shell)
      ("news" :follow #[514 "\301\300\302 Q \"\207" ["news" browse-url ":"]
6 "\n\n(fn URL ARG)"])
      ("mailto" :follow #[514 "\301\300\302 Q \"\207" ["mailto" browse-url
":"] 6 "\n\n(fn URL ARG)"])
      ("https" :follow #[514 "\301\300\302 Q \"\207" ["https" browse-url
":"] 6 "\n\n(fn URL ARG)"])
      ("http" :follow #[514 "\301\300\302 Q \"\207" ["http" browse-url ":"]
6 "\n\n(fn URL ARG)"])
      ("ftp" :follow #[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6
"\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete
org-link-complete-file)
      ("elisp" :follow org-link--open-elisp) ("doi" :follow
org-link--open-doi))
 org-latex-format-headline-function
'org-latex-format-headline-default-function
 org-link-elisp-confirm-function 'bg-org-confirm-elisp-link
 org-clock-idle-time 10
 org-latex-format-inlinetask-function
'org-latex-format-inlinetask-default-function
 org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
 org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-html-format-headline-function
'org-html-format-headline-default-function
 org-confirm-babel-evaluate 'bg-org-confirm-babel-evaluate
 org-directory "/home/brentg/Plans/Home"
 org-publish-project-alist '(("my-emacs-lisp-org" :base-directory
"~/emacs_lisp/" :publishing-directory "~/public_html/emacs_lisp" :recursive
t :table-of-contents t :base-extension "org" :publishing-function
     org-html-publish-to-html :style-include-default nil :section-numbers t
:with-sub-superscript nil :html-head "<link rel=\"stylesheet\"
href=\"org.css\" type=\"text/css\" />"
     :author-info nil :creator-info nil)
    ("my-emacs-lisp-extra" :base-directory "~/emacs_lisp/"
:publishing-directory "~/public_html/emacs_lisp" :base-extension
"css\\|pdf\\|png\\|jpg\\|gif" :publishing-function
     org-publish-attachment :recursive t :author nil)
    ("my-emacs-lisp" :components ("my-emacs-lisp-org"
"my-emacs-lisp-extra")))
 org-default-notes-file "/home/brentg/Plans/Home/notes.org"
 )

[-- Attachment #2: Type: text/html, Size: 9950 bytes --]

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Nicholas Savage]

[-- Attachment #1: Type: text/plain, Size: 8461 bytes --]

I can reproduce this. I'm on the most recent master with Emacs 28.0.50. Once the last line is deleted, org-cycle won't show the "**" line and the minibuffer continues to say "FOLDING" instead of cycling through the various states.

On Sat, Sep 19, 2020, at 12:10, B Goodr wrote:
> Hi,
> 
> Still loving Org mode!!  Keep up the good work.
> 
> Here is a bug, though:
> 
> Steps to reproduce:
> 
> Store the following into some .org file (in between the "cut-here" lines):
> 
> ---cut-here---cut-here---cut-here---cut-here---cut-here---cut-here---
> * TODO aaa bbb ccc
> 
> ** TODO aaa bbb ccc
> 
> delete-this-line-to-see-the-problem
> ---cut-here---cut-here---cut-here---cut-here---cut-here---cut-here---
> 
> Move point at first asterisk (beginning of buffer).
> 
> Type TAB key (bound to org-cycle) multiple times and notice it cycles
> the headings through the various levels of exposure.
> 
> Now go to the end of the buffer, and delete the one line there
> containing "delete-this-line-to-see-the-problem", but retain the two
> empty lines at the end.
> 
> Repeat the above steps with the TAB key at the top of the buffer, and
> notice it stops working.
> 
> On the mailing list, I see some recent changes that might or might not
> have broken this. I've not upgraded Org mode in a while:
> 
> https://lists.gnu.org/archive/html/emacs-orgmode/2020-09/msg00520.html
> 
> Thanks!
> -bgoodr
> 
> 
> 
> Emacs  : GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.14)
>  of 2020-03-26, modified by Debian
> Package: Org mode version 9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)
> 
> current state:
> ==============
> (setq
>  org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
>  org-link-shell-confirm-function 'yes-or-no-p
>  org-babel-after-execute-hook '(bg-org-babel-after-execute-hook)
>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>  org-export-with-sub-superscripts nil
>  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
>  org-refile-targets '((nil :maxlevel . 9) (org-agenda-files :maxlevel . 9))
>  org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
>  org-odt-format-headline-function 'org-odt-format-headline-default-function
>  org-agenda-files "/home/brentg/Plans/Home/org-agenda-files-list-file.txt"
>  org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
>  org-plantuml-jar-path "/home/brentg/plantuml/plantuml.jar"
>  org-startup-folded nil
>  org-id-link-to-org-use-id t
>  org-mode-hook '(org-tempo-setup org-clock-load bg-org-mode-hook #[0 "\301\211 \207" [imenu-create-index-function org-imenu-get-tree] 2]
> #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5]
> #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load)
>  org-clock-persist t
>  org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
>  org-archive-hook '(org-attach-archive-delete-maybe)
>  org-confirm-elisp-link-function 'bg-org-confirm-elisp-link
>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>  org-metaup-hook '(org-babel-load-in-session-maybe)
>  org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3 "\n\n(fn ENTRY)"]
>  org-adapt-indentation nil
>  org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
>  org-babel-pre-tangle-hook '(save-buffer)
>  org-file-apps '((auto-mode . emacs) (directory . emacs) ("\\.mm\\'" . default) ("\\.x?html?\\'" lambda (file link) (browse-url-of-file (expand-file-name file))) ("\\.pdf\\'" . default))
>  org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
>  org-babel-load-languages '((emacs-lisp . t) (python . t) (shell . t) (sqlite . t) (dot . t) (plantuml . t))
>  org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME CONTENTS WIDTH)"]
>  org-agenda-loop-over-headlines-in-active-region nil
>  org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php" . php) ("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" . latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist)
>      ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg) ("screen" . shell-script) ("shell" . sh) ("sqlite" . sql))
>  org-occur-hook '(org-first-headline-recenter)
>  org-html-head-include-default-style nil
>  org-html-htmlize-output-type 'css
>  org-export-headline-levels 100
>  org-edit-src-auto-save-idle-delay 5
>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
>  org-todo-keywords '((sequence "TODO(t)" "|" "DONE(d)" "SHELVED(s)" "DELEGATED(e)"))
>  org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
>  org-clock-persist-file "/home/brentg/Plans/Home/org-clock-save.el"
>  org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
>  org-babel-tangle-lang-exts '(("python" . "py") ("emacs-lisp" . "el") ("elisp" . "el"))
>  org-return-follows-link t
>  org-refile-use-outline-path 'file
>  org-clock-in-hook '(bg-org-clock-in-hook)
>  org-export-before-parsing-hook '(org-attach-expand-links)
>  org-id-locations-file "/home/brentg/Plans/Home/.org-id-locations"
>  org-confirm-shell-link-function 'yes-or-no-p
>  org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link)
>       ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link)
>       ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link)
>       ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link)
>       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link)
>       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell)
>       ("news" :follow #[514 "\301\300\302 Q \"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>       ("mailto" :follow #[514 "\301\300\302 Q \"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>       ("https" :follow #[514 "\301\300\302 Q \"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>       ("http" :follow #[514 "\301\300\302 Q \"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>       ("ftp" :follow #[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file)
>       ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi))
>  org-latex-format-headline-function 'org-latex-format-headline-default-function
>  org-link-elisp-confirm-function 'bg-org-confirm-elisp-link
>  org-clock-idle-time 10
>  org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
>  org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
>  org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
>  org-html-format-headline-function 'org-html-format-headline-default-function
>  org-confirm-babel-evaluate 'bg-org-confirm-babel-evaluate
>  org-directory "/home/brentg/Plans/Home"
>  org-publish-project-alist '(("my-emacs-lisp-org" :base-directory "~/emacs_lisp/" :publishing-directory "~/public_html/emacs_lisp" :recursive t :table-of-contents t :base-extension "org" :publishing-function
>      org-html-publish-to-html :style-include-default nil :section-numbers t :with-sub-superscript nil :html-head "<link rel=\"stylesheet\" href=\"org.css\" type=\"text/css\" />"
>      :author-info nil :creator-info nil)
>     ("my-emacs-lisp-extra" :base-directory "~/emacs_lisp/" :publishing-directory "~/public_html/emacs_lisp" :base-extension "css\\|pdf\\|png\\|jpg\\|gif" :publishing-function
>      org-publish-attachment :recursive t :author nil)
>     ("my-emacs-lisp" :components ("my-emacs-lisp-org" "my-emacs-lisp-extra")))
>  org-default-notes-file "/home/brentg/Plans/Home/notes.org"
>  )

[-- Attachment #2: Type: text/html, Size: 10970 bytes --]

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[stardiviner]

I can reproduce this problem too.

I'm on Emacs 28.0.50 with Org Mode master branch latest commit "aea1109ef".

I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
~org-cycle-hook~ caused this problem.

Nicholas Savage <nick@nicksavage.ca> writes:

> I can reproduce this. I'm on the most recent master with Emacs 28.0.50. Once the last line is deleted, org-cycle won't show the "**" line and the minibuffer continues to say "FOLDING" instead of cycling through the various states.
>
> On Sat, Sep 19, 2020, at 12:10, B Goodr wrote:
>> Hi,
>> 
>> Still loving Org mode!!  Keep up the good work.
>> 
>> Here is a bug, though:
>> 
>> Steps to reproduce:
>> 
>> Store the following into some .org file (in between the "cut-here" lines):
>> 
>> ---cut-here---cut-here---cut-here---cut-here---cut-here---cut-here---
>> * TODO aaa bbb ccc
>> 
>> ** TODO aaa bbb ccc
>> 
>> delete-this-line-to-see-the-problem
>> ---cut-here---cut-here---cut-here---cut-here---cut-here---cut-here---
>> 
>> Move point at first asterisk (beginning of buffer).
>> 
>> Type TAB key (bound to org-cycle) multiple times and notice it cycles
>> the headings through the various levels of exposure.
>> 
>> Now go to the end of the buffer, and delete the one line there
>> containing "delete-this-line-to-see-the-problem", but retain the two
>> empty lines at the end.
>> 
>> Repeat the above steps with the TAB key at the top of the buffer, and
>> notice it stops working.
>> 
>> On the mailing list, I see some recent changes that might or might not
>> have broken this. I've not upgraded Org mode in a while:
>> 
>> https://lists.gnu.org/archive/html/emacs-orgmode/2020-09/msg00520.html
>> 
>> Thanks!
>> -bgoodr
>> 
>> 
>> 
>> Emacs  : GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.14)
>>  of 2020-03-26, modified by Debian
>> Package: Org mode version 9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)
>> 
>> current state:
>> ==============
>> (setq
>>  org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
>>  org-link-shell-confirm-function 'yes-or-no-p
>>  org-babel-after-execute-hook '(bg-org-babel-after-execute-hook)
>>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>>  org-export-with-sub-superscripts nil
>>  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
>>  org-refile-targets '((nil :maxlevel . 9) (org-agenda-files :maxlevel . 9))
>>  org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
>>  org-odt-format-headline-function 'org-odt-format-headline-default-function
>>  org-agenda-files "/home/brentg/Plans/Home/org-agenda-files-list-file.txt"
>>  org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
>>  org-plantuml-jar-path "/home/brentg/plantuml/plantuml.jar"
>>  org-startup-folded nil
>>  org-id-link-to-org-use-id t
>>  org-mode-hook '(org-tempo-setup org-clock-load bg-org-mode-hook #[0 "\301\211 \207" [imenu-create-index-function org-imenu-get-tree] 2]
>> #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5]
>> #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load)
>>  org-clock-persist t
>>  org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
>>  org-archive-hook '(org-attach-archive-delete-maybe)
>>  org-confirm-elisp-link-function 'bg-org-confirm-elisp-link
>>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>>  org-metaup-hook '(org-babel-load-in-session-maybe)
>>  org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3 "\n\n(fn ENTRY)"]
>>  org-adapt-indentation nil
>>  org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
>>  org-babel-pre-tangle-hook '(save-buffer)
>>  org-file-apps '((auto-mode . emacs) (directory . emacs) ("\\.mm\\'" . default) ("\\.x?html?\\'" lambda (file link) (browse-url-of-file (expand-file-name file))) ("\\.pdf\\'" . default))
>>  org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
>>  org-babel-load-languages '((emacs-lisp . t) (python . t) (shell . t) (sqlite . t) (dot . t) (plantuml . t))
>>  org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME CONTENTS WIDTH)"]
>>  org-agenda-loop-over-headlines-in-active-region nil
>>  org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php" . php) ("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" . latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist)
>>      ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg) ("screen" . shell-script) ("shell" . sh) ("sqlite" . sql))
>>  org-occur-hook '(org-first-headline-recenter)
>>  org-html-head-include-default-style nil
>>  org-html-htmlize-output-type 'css
>>  org-export-headline-levels 100
>>  org-edit-src-auto-save-idle-delay 5
>>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
>>  org-todo-keywords '((sequence "TODO(t)" "|" "DONE(d)" "SHELVED(s)" "DELEGATED(e)"))
>>  org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
>>  org-clock-persist-file "/home/brentg/Plans/Home/org-clock-save.el"
>>  org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
>>  org-babel-tangle-lang-exts '(("python" . "py") ("emacs-lisp" . "el") ("elisp" . "el"))
>>  org-return-follows-link t
>>  org-refile-use-outline-path 'file
>>  org-clock-in-hook '(bg-org-clock-in-hook)
>>  org-export-before-parsing-hook '(org-attach-expand-links)
>>  org-id-locations-file "/home/brentg/Plans/Home/.org-id-locations"
>>  org-confirm-shell-link-function 'yes-or-no-p
>>  org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link)
>>       ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link)
>>       ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link)
>>       ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link)
>>       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link)
>>       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell)
>>       ("news" :follow #[514 "\301\300\302 Q \"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>>       ("mailto" :follow #[514 "\301\300\302 Q \"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>>       ("https" :follow #[514 "\301\300\302 Q \"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>>       ("http" :follow #[514 "\301\300\302 Q \"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"])
>>       ("ftp" :follow #[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file)
>>       ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi))
>>  org-latex-format-headline-function 'org-latex-format-headline-default-function
>>  org-link-elisp-confirm-function 'bg-org-confirm-elisp-link
>>  org-clock-idle-time 10
>>  org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
>>  org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
>>  org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
>>  org-html-format-headline-function 'org-html-format-headline-default-function
>>  org-confirm-babel-evaluate 'bg-org-confirm-babel-evaluate
>>  org-directory "/home/brentg/Plans/Home"
>>  org-publish-project-alist '(("my-emacs-lisp-org" :base-directory "~/emacs_lisp/" :publishing-directory "~/public_html/emacs_lisp" :recursive t :table-of-contents t :base-extension "org" :publishing-function
>>      org-html-publish-to-html :style-include-default nil :section-numbers t :with-sub-superscript nil :html-head "<link rel=\"stylesheet\" href=\"org.css\" type=\"text/css\" />"
>>      :author-info nil :creator-info nil)
>>     ("my-emacs-lisp-extra" :base-directory "~/emacs_lisp/" :publishing-directory "~/public_html/emacs_lisp" :base-extension "css\\|pdf\\|png\\|jpg\\|gif" :publishing-function
>>      org-publish-attachment :recursive t :author nil)
>>     ("my-emacs-lisp" :components ("my-emacs-lisp-org" "my-emacs-lisp-extra")))
>>  org-default-notes-file "/home/brentg/Plans/Home/notes.org"
>>  )


-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Bastien]

Hi Nicholas,

"Nicholas Savage" <nick@nicksavage.ca> writes:

> I can reproduce this. 

PS: when confirming a bug, you can add either reply with "Confirmed"
at the beginning of a line, or add X-Woof-Bug: confirmed as a header,
then the bug will appeaer in https://updates.orgmode.org.

See https://github.com/bzg/woof#basic-usage

-- 
 Bastien

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Bastien]

Hi,

stardiviner <numbchild@gmail.com> writes:

> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
> ~org-cycle-hook~ caused this problem.

Did you find the commit that introduces this bug?

Also, if you can provide a patch, please go ahead.

Thanks!

-- 
 Bastien

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[stardiviner]

Bastien <bzg@gnu.org> writes:

> Hi,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
>> ~org-cycle-hook~ caused this problem.
>
> Did you find the commit that introduces this bug?

I did a git bisect test, found the bad commit.

"ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back"

>
> Also, if you can provide a patch, please go ahead.
>

Can't help on this. Don't know much on regexp matching and position boundries etc.

Will keep improving skill.

-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Ihor Radchenko]

[-- Attachment #1: Type: text/plain, Size: 67 bytes --]

> Also, if you can provide a patch, please go ahead.

Here it is.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-remove-trailing-newline-when-deleting-plannin.patch --]
[-- Type: text/x-diff, Size: 1607 bytes --]

From 8e99e5dea780041d314f666f506a120224f064eb Mon Sep 17 00:00:00 2001
From: Ihor Radchenko <yantar92@gmail.com>
Date: Wed, 23 Sep 2020 21:54:47 +0800
Subject: [PATCH] Do not remove trailing newline when deleting planning info
 line.

* lisp/org.el (org-add-planning-info): Remove front newline instead of
trailing newline when deleting planning info is completetly removed
from a heading.  Fixes "Cycling through TODO workflow joins the next
line onto the current one".

The old behaviour affected folded headlines containing only planning
info in the body:

Before deletion:
* DONE Headline<begin fold>
  CLOSED: [2020-09-23 Wed 21:39]<end fold>
* test

After deletion:
* DONE Headline<begin fold>
<end fold>* test

The newline after the first headline is hidden making both the
headlines appear at the same visual line.

New behaviour:
After deletion:
* DONE Headline
* test

All the folded text is completely removed.
---
 lisp/org.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index a9fdc7b77..845920a71 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10684,8 +10684,8 @@ WHAT entry will also be removed."
 	 ;; If there is nothing more to add and no more keyword is
 	 ;; left, remove the line completely.
 	 (if (and (looking-at-p "[ \t]*$") (not what))
-	     (delete-region (line-beginning-position)
-			    (line-beginning-position 2))
+	     (delete-region (line-end-position 0)
+			    (line-end-position))
 	   ;; If we removed last keyword, do not leave trailing white
 	   ;; space at the end of line.
 	   (let ((p (point)))
-- 
2.26.2


[-- Attachment #3: Type: text/plain, Size: 354 bytes --]



Bastien <bzg@gnu.org> writes:

> Hi,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
>> ~org-cycle-hook~ caused this problem.
>
> Did you find the commit that introduces this bug?
>
> Also, if you can provide a patch, please go ahead.
>
> Thanks!
>
> -- 
>  Bastien

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Ihor Radchenko]

> I did a git bisect test, found the bad commit.
> "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back"

Additional observation:
The unfolding does not happen because org-cycle-show-empty-lines
_always_ reveals trailing empty lines at the end of buffer. It breaks
the assumption in org-cycle-internal-local that end of folded subtree
must always be the same as the end of the folded region.

Before ee3c3b554, that situation was handled by additional check, but it
is not the case anymore.

Best,
Ihor


stardiviner <numbchild@gmail.com> writes:

> Bastien <bzg@gnu.org> writes:
>
>> Hi,
>>
>> stardiviner <numbchild@gmail.com> writes:
>>
>>> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
>>> ~org-cycle-hook~ caused this problem.
>>
>> Did you find the commit that introduces this bug?
>
> I did a git bisect test, found the bad commit.
>
> "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back"
>
>>
>> Also, if you can provide a patch, please go ahead.
>>
>
> Can't help on this. Don't know much on regexp matching and position boundries etc.
>
> Will keep improving skill.
>
> -- 
> [ stardiviner ]
>        I try to make every word tell the meaning that I want to express.
>
>        Blog: https://stardiviner.github.io/
>        IRC(freenode): stardiviner, Matrix: stardiviner
>        GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Kyle Meyer]

Ihor Radchenko writes:

> Subject: [PATCH] Do not remove trailing newline when deleting planning info
>  line.
>
> * lisp/org.el (org-add-planning-info): Remove front newline instead of
> trailing newline when deleting planning info is completetly removed
> from a heading.  Fixes "Cycling through TODO workflow joins the next
> line onto the current one".

Did you intended to send a different patch?  This looks to be the same
patch you sent at <https://orgmode.org/list/87ft78608z.fsf@localhost>.

Also, can someone could provide an example case that was fixed by
ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)?
The report that prompted that commit didn't include one:
https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com

I tried with

--8<---------------cut here---------------start------------->8---

* TODO a

* TODO b
--8<---------------cut here---------------end--------------->8---

If I understand the original message by Dmitrii (+cc), the request was
that, since starting up folded shows the first heading as

    * TODO a...

tab should be able to fold the heading back to that state after
expansion.  But, trying with the current master (16f505db2), tab still
doesn't fold that heading on my end.  Unless we have a concrete reason
to keep ee3c3b554, reverting it might be the best fix for this thread's
issue.

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Ihor Radchenko]

> Did you intended to send a different patch?  This looks to be the same
> patch you sent at <https://orgmode.org/list/87ft78608z.fsf@localhost>.

I have no patch for the bug report in this thread. The patch I sent was
intended for https://orgmode.org/list/87ft78608z.fsf@localhost.

> But, trying with the current master (16f505db2), tab still doesn't
> fold that heading on my end.

Same on my end.

Best,
Ihor

Kyle Meyer <kyle@kyleam.com> writes:

> Ihor Radchenko writes:
>
>> Subject: [PATCH] Do not remove trailing newline when deleting planning info
>>  line.
>>
>> * lisp/org.el (org-add-planning-info): Remove front newline instead of
>> trailing newline when deleting planning info is completetly removed
>> from a heading.  Fixes "Cycling through TODO workflow joins the next
>> line onto the current one".
>
> Did you intended to send a different patch?  This looks to be the same
> patch you sent at <https://orgmode.org/list/87ft78608z.fsf@localhost>.
>
> Also, can someone could provide an example case that was fixed by
> ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)?
> The report that prompted that commit didn't include one:
> https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com
>
> I tried with
>
> --8<---------------cut here---------------start------------->8---
>
> * TODO a
>
> * TODO b
> --8<---------------cut here---------------end--------------->8---
>
> If I understand the original message by Dmitrii (+cc), the request was
> that, since starting up folded shows the first heading as
>
>     * TODO a...
>
> tab should be able to fold the heading back to that state after
> expansion.  But, trying with the current master (16f505db2), tab still
> doesn't fold that heading on my end.  Unless we have a concrete reason
> to keep ee3c3b554, reverting it might be the best fix for this thread's
> issue.

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[stardiviner]

Kyle Meyer <kyle@kyleam.com> writes:

> Ihor Radchenko writes:
>
>> Subject: [PATCH] Do not remove trailing newline when deleting planning info
>>  line.
>>
>> * lisp/org.el (org-add-planning-info): Remove front newline instead of
>> trailing newline when deleting planning info is completetly removed
>> from a heading.  Fixes "Cycling through TODO workflow joins the next
>> line onto the current one".
>
> Did you intended to send a different patch?  This looks to be the same
> patch you sent at <https://orgmode.org/list/87ft78608z.fsf@localhost>.
>
> Also, can someone could provide an example case that was fixed by
> ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)?
> The report that prompted that commit didn't include one:
> https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com
>
> I tried with
>
> --8<---------------cut here---------------start------------->8---
>
> * TODO a
>
> * TODO b
> --8<---------------cut here---------------end--------------->8---
>
> If I understand the original message by Dmitrii (+cc), the request was
> that, since starting up folded shows the first heading as
>
>     * TODO a...
>
> tab should be able to fold the heading back to that state after
> expansion.  But, trying with the current master (16f505db2), tab still
> doesn't fold that heading on my end.  Unless we have a concrete reason
> to keep ee3c3b554, reverting it might be the best fix for this thread's
> issue.

Waited many days, seems no useful patch available. I suggest to revert that
commit.

-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Bastien]

stardiviner <numbchild@gmail.com> writes:

> Waited many days, seems no useful patch available. I suggest to revert that
> commit.

I will have a look over the week-end, thanks.

-- 
 Bastien

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[stardiviner]

Bastien <bzg@gnu.org> writes:

> stardiviner <numbchild@gmail.com> writes:
>
>> Waited many days, seems no useful patch available. I suggest to revert that
>> commit.
>
> I will have a look over the week-end, thanks.

Thanks for taking time to look at this problem, Bastien.

-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[stardiviner]

A simple temporary solution to this bug is remove hook function from ~org-cycle-hook~:

#+begin_src emacs-lisp
(remove-hook 'org-cycle-hook #'org-cycle-show-empty-lines)
#+end_src

stardiviner <numbchild@gmail.com> writes:

> Bastien <bzg@gnu.org> writes:
>
>> Hi,
>>
>> stardiviner <numbchild@gmail.com> writes:
>>
>>> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
>>> ~org-cycle-hook~ caused this problem.
>>
>> Did you find the commit that introduces this bug?
>
> I did a git bisect test, found the bad commit.
>
> "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back"
>
>>
>> Also, if you can provide a patch, please go ahead.
>>
>
> Can't help on this. Don't know much on regexp matching and position boundries etc.
>
> Will keep improving skill.


-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Kyle Meyer]

stardiviner writes:

> Bastien <bzg@gnu.org> writes:
>
>> stardiviner <numbchild@gmail.com> writes:
>>
>>> Waited many days, seems no useful patch available. I suggest to revert that
>>> commit.
>>
>> I will have a look over the week-end, thanks.
>
> Thanks for taking time to look at this problem, Bastien.

As discussed at <https://orgmode.org/list/87o8kq3lga.fsf@kyleam.com>,
this doesn't appear to have fixed the original issue.  Reverted in
e8070d71a.