emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: numbchild@gmail.com, Bastien <bzg@gnu.org>
Cc: Nicholas Savage <nick@nicksavage.ca>, emacs-orgmode@gnu.org
Subject: Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Wed, 23 Sep 2020 23:07:51 +0800	[thread overview]
Message-ID: <87d02c5y60.fsf@localhost> (raw)
In-Reply-To: <5f6b56a1.1c69fb81.ea6da.e0f1@mx.google.com>

> I did a git bisect test, found the bad commit.
> "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back"

Additional observation:
The unfolding does not happen because org-cycle-show-empty-lines
_always_ reveals trailing empty lines at the end of buffer. It breaks
the assumption in org-cycle-internal-local that end of folded subtree
must always be the same as the end of the folded region.

Before ee3c3b554, that situation was handled by additional check, but it
is not the case anymore.

Best,
Ihor


stardiviner <numbchild@gmail.com> writes:

> Bastien <bzg@gnu.org> writes:
>
>> Hi,
>>
>> stardiviner <numbchild@gmail.com> writes:
>>
>>> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook
>>> ~org-cycle-hook~ caused this problem.
>>
>> Did you find the commit that introduces this bug?
>
> I did a git bisect test, found the bad commit.
>
> "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back"
>
>>
>> Also, if you can provide a patch, please go ahead.
>>
>
> Can't help on this. Don't know much on regexp matching and position boundries etc.
>
> Will keep improving skill.
>
> -- 
> [ stardiviner ]
>        I try to make every word tell the meaning that I want to express.
>
>        Blog: https://stardiviner.github.io/
>        IRC(freenode): stardiviner, Matrix: stardiviner
>        GPG: F09F650D7D674819892591401B5DF1C95AE89AC3


  reply	other threads:[~2020-09-23 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 16:10 B Goodr
2020-09-19 18:09 ` Nicholas Savage
2020-09-23  1:19   ` stardiviner
2020-09-23 12:19     ` Bastien
2020-09-23 14:07       ` stardiviner
2020-09-23 15:07         ` Ihor Radchenko [this message]
2020-10-18  7:20         ` stardiviner
2020-09-23 14:13       ` [PATCH] " Ihor Radchenko
2020-09-28  5:08         ` Kyle Meyer
2020-09-28  5:34           ` Ihor Radchenko
2020-10-03  7:34           ` stardiviner
2020-10-03  8:48             ` Bastien
2020-10-03 11:04               ` stardiviner
2020-10-27  4:11                 ` Kyle Meyer
2020-09-23 12:18   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d02c5y60.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=nick@nicksavage.ca \
    --cc=numbchild@gmail.com \
    --subject='Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).