emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: B Goodr <bgoodr@gmail.com>,
	Dmitrii Korobeinikov <dim1212k@gmail.com>, Bastien <bzg@gnu.org>,
	emacs-orgmode@gnu.org, Nicholas Savage <nick@nicksavage.ca>
Subject: Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Mon, 28 Sep 2020 01:08:35 -0400	[thread overview]
Message-ID: <87tuviqyi4.fsf@kyleam.com> (raw)
In-Reply-To: <87lfh060pb.fsf@localhost>

Ihor Radchenko writes:

> Subject: [PATCH] Do not remove trailing newline when deleting planning info
>  line.
>
> * lisp/org.el (org-add-planning-info): Remove front newline instead of
> trailing newline when deleting planning info is completetly removed
> from a heading.  Fixes "Cycling through TODO workflow joins the next
> line onto the current one".

Did you intended to send a different patch?  This looks to be the same
patch you sent at <https://orgmode.org/list/87ft78608z.fsf@localhost>.

Also, can someone could provide an example case that was fixed by
ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)?
The report that prompted that commit didn't include one:
https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com

I tried with

--8<---------------cut here---------------start------------->8---

* TODO a

* TODO b
--8<---------------cut here---------------end--------------->8---

If I understand the original message by Dmitrii (+cc), the request was
that, since starting up folded shows the first heading as

    * TODO a...

tab should be able to fold the heading back to that state after
expansion.  But, trying with the current master (16f505db2), tab still
doesn't fold that heading on my end.  Unless we have a concrete reason
to keep ee3c3b554, reverting it might be the best fix for this thread's
issue.


  reply	other threads:[~2020-09-28  5:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 16:10 B Goodr
2020-09-19 18:09 ` Nicholas Savage
2020-09-23  1:19   ` stardiviner
2020-09-23 12:19     ` Bastien
2020-09-23 14:07       ` stardiviner
2020-09-23 15:07         ` Ihor Radchenko
2020-10-18  7:20         ` stardiviner
2020-09-23 14:13       ` [PATCH] " Ihor Radchenko
2020-09-28  5:08         ` Kyle Meyer [this message]
2020-09-28  5:34           ` Ihor Radchenko
2020-10-03  7:34           ` stardiviner
2020-10-03  8:48             ` Bastien
2020-10-03 11:04               ` stardiviner
2020-10-27  4:11                 ` Kyle Meyer
2020-09-23 12:18   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuviqyi4.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bgoodr@gmail.com \
    --cc=bzg@gnu.org \
    --cc=dim1212k@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nick@nicksavage.ca \
    --cc=yantar92@gmail.com \
    --subject='Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).