From: Ian Kelling <ianowl@gmail.com>
To: "'emacs-orgmode@gnu.org'" <emacs-orgmode@gnu.org>
Subject: [PATCH] Make the point visible when jumping to the mark
Date: Sun, 15 Sep 2013 02:22:03 -0700 [thread overview]
Message-ID: <52357C3B.4080605@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
An example of the problem:
* headline-1
** one of many headlines I want to remain folded...
** headline
*** headline
The point starts here. I set a mark on this line.
Then I fold headline-1. This becomes invisible.
* headline-2
I move the point here. After I'm done here, I want to go back to my
mark. I do C-u C-space (pop-to-mark-command), but it doesn't go to the
mark. Instead, it takes me to the end of the still folded
headline-1. To get back to my mark without globally unfolding
everything requires tediously unfolding each headline and sub-headline
until the marked location is exposed.
There are some other non-org commands that would have this same
problem (isearch, bookmark-jump, save-place), but org-mode has code to
fix them. org-mark-ring-goto also handles this. I followed those examples
and wrote a patch. It is attached.
- Ian Kelling
[-- Attachment #2: 0001-Make-the-point-visible-when-jumping-to-the-mark.patch --]
[-- Type: text/x-patch, Size: 1612 bytes --]
From 066595dd9350f06a1df2e99a341f96782ac8dfed Mon Sep 17 00:00:00 2001
From: Ian Kelling <ianowl@gmail.com>
Date: Sun, 15 Sep 2013 00:32:08 -0700
Subject: [PATCH] Make the point visible when jumping to the mark
* lisp/org.el advise `pop-global-mark', `exchange-point-and-mark', and
`pop-global-mark' with `org-show-context', as appropriate.
TINYCHANGE
---
lisp/org.el | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/lisp/org.el b/lisp/org.el
index 8e970a1..30b87d9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -23903,6 +23903,27 @@ To get rid of the restriction, use \\[org-agenda-remove-restriction-lock]."
(outline-invisible-p)))
(org-show-context 'bookmark-jump)))
+(eval-after-load "simple"
+ '(defadvice set-mark-command (after org-make-visible activate)
+ "Make the point visible with `org-show-context'."
+ (org-mark-jump-unhide)))
+
+(eval-after-load "simple"
+ '(defadvice exchange-point-and-mark (after org-make-visible activate)
+ "Make the point visible with `org-show-context'."
+ (org-mark-jump-unhide)))
+
+(eval-after-load "simple"
+ '(defadvice pop-global-mark (after org-make-visible activate)
+ "Make the point visible with `org-show-context'."
+ (org-mark-jump-unhide)))
+
+(defun org-mark-jump-unhide ()
+ "Make the point visible with `org-show-context' after jumping to the mark."
+ (and (derived-mode-p 'org-mode)
+ (outline-invisible-p)
+ (org-show-context 'mark-goto)))
+
;; Make session.el ignore our circular variable
(defvar session-globals-exclude)
(eval-after-load "session"
--
1.8.3.1
next reply other threads:[~2013-09-15 9:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 9:22 Ian Kelling [this message]
2013-09-15 17:25 ` [PATCH] Make the point visible when jumping to the mark Ian Kelling
-- strict thread matches above, loose matches on Subject: below --
2014-05-01 4:54 Ian Kelling
2014-05-20 22:25 ` Ian Kelling
2014-05-21 2:58 ` Bastien
2014-05-21 9:21 ` Ian Kelling
2014-05-21 13:00 ` Bastien
2014-05-21 19:01 ` Ian Kelling
2014-05-22 9:54 ` Bastien
2014-05-22 8:56 ` Sebastien Vauban
2014-05-22 9:52 ` Bastien
2014-05-22 15:40 ` Ian Kelling
2014-05-23 5:47 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52357C3B.4080605@gmail.com \
--to=ianowl@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).