Re: [PATCH] Improve configurability of ox-koma-letter

[Viktor Rosenfeld <listuser36@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

Hi Rasmus and Alan,

I've changed the code so the value for foldmarks is passed through to
KOMA-Script. It's a bit ugly insofar as one has to specify
foldmarks:true to use the default values instead of other options, such
as backaddress:t. However, subject also uses a string already.

See the attached patch.

Cheers,
Viktor

Rasmus wrote:

> Viktor Rosenfeld <listuser36@gmail.com> writes:
> 
> >> Yeah, I guess it's true.  Still, since foldmarks depends on which
> >> envelopes you have at hand it might make sense to have it accept a
> >> string.  In lisp-terms a string is still t.  On the other hand the
> >> current approach is consistent with your approach above so that's a
> >> merit.
> >
> > The more I think about it the more I agree that you should be able to
> > set any value of foldmarks. The only problem I see is that for other
> > boolean options one can use `t' whereas for foldmarks one would need to
> > use `true' (because `t' is a valid configuration value for foldmarks).
> > But as long as that's documented I see no problem. I will post a patch,
> > once Alan applies my previous patches.
> 
> I don't know the details of the exporter well enough on this detail,
> but perhaps it can be utilized that t ≠ "t"; if that's true in the
> exporter as well.  In normal lisp (characterp "t") => t and
> (characterp t) nil.  But I'm not sure if t would be transformed before
> being able to check. . . 
> 
> Thanks,
> Rasmus
> 
> -- 
> May the Force be with you
> 

[-- Attachment #2: 0002-ox-koma-letter.el-Give-the-user-complete-control-ove.patch --]
[-- Type: text/plain, Size: 1804 bytes --]

From b506dd781404a999056a0348fb7f3eb8c8ef4524 Mon Sep 17 00:00:00 2001
From: Viktor Rosenfeld <listuser36@gmail.com>
Date: Sun, 5 May 2013 15:22:51 +0200
Subject: [PATCH 2/2] ox-koma-letter.el: Give the user complete control over
 foldmarks appearance.

	* ox-koma-letter.el (org-koma-letter-use-foldmarks) Update
	documentation
	(org-koma-letter-template): Pass foldmarks setting to
	KOMA-Script

TINYCHANGE
---
 contrib/lisp/ox-koma-letter.el | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/contrib/lisp/ox-koma-letter.el b/contrib/lisp/ox-koma-letter.el
index 37ff903..96c0569 100644
--- a/contrib/lisp/ox-koma-letter.el
+++ b/contrib/lisp/ox-koma-letter.el
@@ -130,10 +130,15 @@
   :group 'org-export-koma-letter
   :type 'boolean)
 
-(defcustom org-koma-letter-use-foldmarks t
-  "Print foldmarks."
+(defcustom org-koma-letter-use-foldmarks "true"
+  "Configure appearence of fold marks.
+
+Accepts any valid value for the KOMA-Script `foldmarks' option.
+
+Use `foldmarks:true' to activate default fold marks or
+`foldmarks:nil' to deactivate fold marks."
   :group 'org-export-koma-letter
-  :type 'boolean)
+  :type 'string)
 
 (defcustom org-koma-letter-use-phone t
   "Print sender's phone number."
@@ -286,7 +291,7 @@ holding export options."
 	 (with-email (plist-get info :with-email)))
      (concat
       (format "\\KOMAoption{backaddress}{%s}\n" (if with-backaddress "true" "false"))
-      (format "\\KOMAoption{foldmarks}{%s}\n" (if with-foldmarks "true" "false"))
+      (format "\\KOMAoption{foldmarks}{%s}\n" (if with-foldmarks with-foldmarks "false"))
       (format "\\KOMAoption{fromphone}{%s}\n" (if with-phone "true" "false"))
       (format "\\KOMAoption{fromemail}{%s}\n" (if with-email "true" "false"))))
    ;; Document start
-- 
1.8.2.2