From: Viktor Rosenfeld <listuser36@gmail.com>
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Improve configurability of ox-koma-letter
Date: Sun, 5 May 2013 15:25:11 +0200 [thread overview]
Message-ID: <20130505132511.GA2898@kenny.local> (raw)
In-Reply-To: <m24nex372v.fsf@polytechnique.org>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
Hi Alan,
I've removed the defaults from OPENING and CLOSING. See the attached
patch.
Cheers,
Viktor
Alan Schmitt wrote:
> Viktor Rosenfeld writes:
>
> > Rasmus also suggested setting the default opening and closing to nil
> > because we should not assume that everybody speaks English. Maybe, every
> > variable should default to nil.
>
> Yes, I think it's a good idea. I often have lines that set the opening
> and closing to '~' to avoid having them.
>
> Alan
>
[-- Attachment #2: 0001-ox-koma-letter.el-No-default-opening-and-closing-lin.patch --]
[-- Type: text/plain, Size: 1286 bytes --]
From 1455bc78d87649ff2b41760f382c20fae4ecd585 Mon Sep 17 00:00:00 2001
From: Viktor Rosenfeld <listuser36@gmail.com>
Date: Sun, 5 May 2013 15:11:15 +0200
Subject: [PATCH 1/2] ox-koma-letter.el: No default opening and closing line.
* ox-koma-letter.el (org-koma-letter-opening): No default / set to nil.
(org-koma-letter-closing): No default / set to nil.
We should not assume a formal English opening and closing
line. A letter requires many personal options, such as the
address, so it is no more work to also these options.
TINYCHANGE
---
contrib/lisp/ox-koma-letter.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/ox-koma-letter.el b/contrib/lisp/ox-koma-letter.el
index 31ccd89..37ff903 100644
--- a/contrib/lisp/ox-koma-letter.el
+++ b/contrib/lisp/ox-koma-letter.el
@@ -105,12 +105,12 @@
:group 'org-export-koma-letter
:type 'string)
-(defcustom org-koma-letter-opening "Dear Madam or Sir,"
+(defcustom org-koma-letter-opening nil
"Letter's opening, as a string."
:group 'org-export-koma-letter
:type 'string)
-(defcustom org-koma-letter-closing "Sincerely yours,"
+(defcustom org-koma-letter-closing nil
"Koma-Letter's closing, as a string."
:group 'org-export-koma-letter
:type 'string)
--
1.8.2.2
next prev parent reply other threads:[~2013-05-05 13:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 17:59 [PATCH] Improve configurability of ox-koma-letter Viktor Rosenfeld
2013-04-22 8:24 ` Alan Schmitt
2013-04-22 8:47 ` Nicolas Goaziou
2013-04-22 9:31 ` Alan Schmitt
2013-04-22 10:57 ` Viktor Rosenfeld
2013-04-22 12:06 ` Alan Schmitt
2013-04-22 19:14 ` Viktor Rosenfeld
2013-04-23 6:40 ` Alan Schmitt
2013-04-23 9:50 ` Viktor Rosenfeld
2013-04-23 9:54 ` Alan Schmitt
2013-05-05 13:25 ` Viktor Rosenfeld [this message]
2013-05-05 16:24 ` Alan Schmitt
2013-04-23 7:28 ` Alan Schmitt
2013-04-23 10:09 ` Viktor Rosenfeld
2013-04-23 11:11 ` Alan Schmitt
2013-04-22 10:49 ` Viktor Rosenfeld
2013-05-05 13:35 ` Viktor Rosenfeld
2013-05-05 17:07 ` Alan Schmitt
2013-05-14 16:09 ` Viktor Rosenfeld
2013-05-14 21:20 ` Rasmus
2013-05-16 18:35 ` Viktor Rosenfeld
2013-05-14 23:56 ` Thomas S. Dye
2013-05-16 18:35 ` Viktor Rosenfeld
2013-05-15 6:38 ` Alan Schmitt
2013-05-14 22:29 ` Suvayu Ali
2013-05-16 18:35 ` Viktor Rosenfeld
2013-04-22 9:57 ` Rasmus
2013-04-22 11:27 ` Viktor Rosenfeld
2013-04-22 12:09 ` Rasmus
2013-04-22 19:22 ` Viktor Rosenfeld
2013-04-23 23:46 ` Rasmus
2013-05-05 13:27 ` Viktor Rosenfeld
2013-05-05 16:33 ` Alan Schmitt
2013-05-05 16:44 ` Viktor Rosenfeld
2013-05-05 17:06 ` Alan Schmitt
2013-04-24 0:05 ` Rasmus
2013-05-05 13:30 ` Viktor Rosenfeld
2013-04-22 17:13 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130505132511.GA2898@kenny.local \
--to=listuser36@gmail.com \
--cc=alan.schmitt@polytechnique.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).