emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: Viktor Rosenfeld <listuser36@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Improve configurability of ox-koma-letter
Date: Mon, 22 Apr 2013 14:06:36 +0200	[thread overview]
Message-ID: <m2haiy7os3.fsf@polytechnique.org> (raw)
In-Reply-To: <20130422105742.GD7821@cartman>

Viktor Rosenfeld writes:

> Hi Alan,
>
> Alan Schmitt wrote:
>
>> A couple notes about the patch:
>> - Could you create it using "git format-patch"? This way we'll have
>> more metadata in the commit.
>
> I actually did that first and liked it more because then the patch was
> split into more logical blocks (nine patches in total). However, I did
> not add correct changelog entries to the commits. Should I resend the
> individual patches nevertheless? I could add/change the commit message
> manually in the email, I suppose.

Or you could do a git rebase interactive to merge all the commits
together.

>> - I think there is an issue with the handling of signatures. I tried
>> with an old letter that uses a LCO with a graphical signature in it, but
>> it gets overridden upon export. Here is the generated TeX.
>> 
>> #+BEGIN_SRC latex
>> \LoadLetterOption{InriaRennesFR}
>> \setkomavar{signature}{\usekomavar{fromname}}
>> #+END_SRC
>> 
>
> Have you tried clearing the signature?
>
> #+BEGIN_SRC emacs-lisp
> (setq org-koma-letter-signature nil)
> #+END_SRC

Yes, I changed it globally and I still get the same thing. I also
tried doing a

#+BEGIN_SRC org
#+signature: ""
#+END_SRC

and it inserts it in the LaTeX file as such, after my LCO declaration.

Alan

next prev parent reply	other threads:[~2013-04-22 12:06 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-21 17:59 [PATCH] Improve configurability of ox-koma-letter Viktor Rosenfeld
2013-04-22  8:24 ` Alan Schmitt
2013-04-22  8:47   ` Nicolas Goaziou
2013-04-22  9:31     ` Alan Schmitt
2013-04-22 10:57       ` Viktor Rosenfeld
2013-04-22 12:06         ` Alan Schmitt [this message]
2013-04-22 19:14           ` Viktor Rosenfeld
2013-04-23  6:40             ` Alan Schmitt
2013-04-23  9:50               ` Viktor Rosenfeld
2013-04-23  9:54                 ` Alan Schmitt
2013-05-05 13:25                   ` Viktor Rosenfeld
2013-05-05 16:24                     ` Alan Schmitt
2013-04-23  7:28             ` Alan Schmitt
2013-04-23 10:09               ` Viktor Rosenfeld
2013-04-23 11:11                 ` Alan Schmitt
2013-04-22 10:49   ` Viktor Rosenfeld
2013-05-05 13:35   ` Viktor Rosenfeld
2013-05-05 17:07     ` Alan Schmitt
2013-05-14 16:09       ` Viktor Rosenfeld
2013-05-14 21:20         ` Rasmus
2013-05-16 18:35           ` Viktor Rosenfeld
2013-05-14 23:56         ` Thomas S. Dye
2013-05-16 18:35           ` Viktor Rosenfeld
2013-05-15  6:38         ` Alan Schmitt
2013-05-14 22:29     ` Suvayu Ali
2013-05-16 18:35       ` Viktor Rosenfeld
2013-04-22  9:57 ` Rasmus
2013-04-22 11:27   ` Viktor Rosenfeld
2013-04-22 12:09     ` Rasmus
2013-04-22 19:22       ` Viktor Rosenfeld
2013-04-23 23:46         ` Rasmus
2013-05-05 13:27           ` Viktor Rosenfeld
2013-05-05 16:33             ` Alan Schmitt
2013-05-05 16:44               ` Viktor Rosenfeld
2013-05-05 17:06                 ` Alan Schmitt
2013-04-24  0:05         ` Rasmus
2013-05-05 13:30           ` Viktor Rosenfeld
2013-04-22 17:13   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2haiy7os3.fsf@polytechnique.org \
    --to=alan.schmitt@polytechnique.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=listuser36@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).