Re: [PATCH] Separate clocksum format for durations >= 1 day

[Toby Cubitt <tsc25@cantab.net>]

On Mon, Nov 05, 2012 at 01:20:48PM +0100, Nicolas Goaziou wrote:
> Toby Cubitt <tsc25@cantab.net> writes:
[snip]
> > [...] what about getting rid of every customization option except
> > `org-time-clocksum-format', and parsing the format string itself to
> > decide how many and what arguments to pass to it?
> >
> > More precisely, if the format string contains ":", "." or "," then the
> > smallest time component is minutes; otherwise it's hours. Pass as many
> > time components as necessary to fill all the "%" expandos in the format
> > string, from largest to smallest, with either hours or minutes as the
> > smallest. If the format string contains "." or "," then pass the number
> > of minutes as a fraction ("," is used as the decimal separator in many
> > European languages).
> 
> That would be over-engineering it.
> 
> > This would simplify things, and make the format string just "do the right
> > thing" in all the cases I listed above. On the other hand, it won't allow
> > unusual formats that don't fit the above scheme (but they're not possible
> > now, anyway).
> >
> > Thoughts?
> 
> I think it's too much complicated: it requires to know about strange
> formatting rules. I suggest to keep it simple: just specify a function
> with fixed arguments to do the job and provide default functions to
> handle most common cases.

I'm fine with a function + sensible defaults, but Achim didn't like it
and proposed a custom format syntax instead.

org-time-clocksum-format is used all over the place in org-clock.el,
often concatenated with other bits of format string. So the changes
needed to change it into "one function to rule them all" are more
extensive, though fairly trivial.

I'd prefer to see some agreement before I waste time coding something
that won't get accepted.

Toby
-- 
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain

email: tsc25@cantab.net
web:   www.dr-qubit.org