From: Nicolas Goaziou <n.goaziou@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Separate clocksum format for durations >= 1 day
Date: Fri, 09 Nov 2012 09:04:02 +0100 [thread overview]
Message-ID: <87mwyrjj7x.fsf@gmail.com> (raw)
In-Reply-To: <20121108112857.GA4911@c3po> (Toby Cubitt's message of "Thu, 8 Nov 2012 12:28:57 +0100")
Toby Cubitt <tsc25@cantab.net> writes:
> Minor point: I would order the format strings minutes, hours, days. In
> case we ever want to extend to months or years, that way we can simply
> extend the list and it will be completely backwards compatible.
Using a plist can circumvent the problem, too. I'm ok either way.
> One other thing that needs some thought (which I already mentioned
> previously). The minutes format string needs to change, depending on
> whether the data format is fractional or regular.
Not necessarily. The format string can use %s. We can also remind it in
the docstring of both variables and provide examples.
> So if a user wants to switch to fractional, it's not enough to set the
> first variable; they have to *also* change the minute format string.
> If they don't the durations will be garbled.
Sometimes, yes.
> A customization setter function could be used to change the value of the
> second variable when the first one is modified through customize. But
> that quickly gets complex, e.g. we have to be careful about clobbering
> any customizations the user has already made to the format strings.
That sounds too complicated.
> The simpler solution would be to always have two format strings for the
> minutes in the list: a fractional format, and a regular format. This
> shouldn't be too confusing as long as it's documented in the variable
> docstring and there are good descriptive :tags for each list element in
> the customization type.
I think this is not necessary. We can just document the fact that the
user must check both variables before applying some change. Anyway,
I let you judge this.
> Looks good to me, and lets me do what I wanted in my original patch.
>
> Now I just need to find time to code it up...
Good to hear we eventually settled on a solution !
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2012-11-09 8:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 14:01 [PATCH] Separate clocksum format for durations >= 1 day Toby Cubitt
2012-11-05 9:14 ` Nicolas Goaziou
2012-11-05 10:25 ` Toby Cubitt
2012-11-05 10:47 ` Achim Gratz
2012-11-05 11:01 ` Toby Cubitt
2012-11-05 11:13 ` Achim Gratz
2012-11-05 12:10 ` Toby Cubitt
2012-11-05 12:20 ` Nicolas Goaziou
2012-11-05 12:55 ` Toby Cubitt
2012-11-05 13:14 ` Nicolas Goaziou
2012-11-05 17:40 ` Achim Gratz
2012-11-05 18:16 ` Toby Cubitt
2012-11-05 22:45 ` Nicolas Goaziou
2012-11-06 10:35 ` Toby Cubitt
2012-11-06 10:57 ` Nicolas Goaziou
2012-11-06 12:01 ` Toby Cubitt
2012-11-06 12:29 ` Nicolas Goaziou
2012-11-06 13:04 ` Toby Cubitt
2012-11-06 17:41 ` Nicolas Goaziou
2012-11-06 19:26 ` Toby Cubitt
2012-11-06 19:55 ` Nicolas Goaziou
2012-11-06 20:35 ` Toby Cubitt
2012-11-08 0:26 ` Nicolas Goaziou
2012-11-08 11:28 ` Toby Cubitt
2012-11-09 8:04 ` Nicolas Goaziou [this message]
2012-11-13 13:03 ` Toby Cubitt
2012-11-14 15:04 ` Nicolas Goaziou
2012-11-14 15:37 ` Toby Cubitt
2012-11-14 16:09 ` Nicolas Goaziou
2012-11-14 16:20 ` Toby Cubitt
2012-11-16 15:12 ` Toby Cubitt
2012-11-17 8:48 ` Nicolas Goaziou
2012-11-17 14:00 ` Toby Cubitt
2012-11-17 14:42 ` Nicolas Goaziou
2012-11-17 16:02 ` Toby Cubitt
2012-11-20 16:12 ` Mike McLean
2012-11-20 17:28 ` Toby Cubitt
2012-11-20 19:24 ` Nicolas Goaziou
2012-11-21 23:29 ` Mike McLean
2012-11-30 11:22 ` [bug] " Sebastien Vauban
2012-11-06 18:42 ` [PATCH] " Achim Gratz
2012-11-06 20:10 ` Toby Cubitt
2012-11-06 20:49 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwyrjj7x.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).