From: Toby Cubitt <tsc25@cantab.net>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Separate clocksum format for durations >= 1 day
Date: Tue, 6 Nov 2012 11:35:46 +0100 [thread overview]
Message-ID: <20121106103546.GA9407@c3po> (raw)
In-Reply-To: <87y5ifacu3.fsf@gmail.com>
On Mon, Nov 05, 2012 at 11:45:24PM +0100, Nicolas Goaziou wrote:
> Toby Cubitt <tsc25@cantab.net> writes:
> >> This is not far from your own suggestion to provide different functions
> >> depending on which output is desired, I just happen to think that these
> >> functions would all be so similar that they should be rolled into a
> >> single function that can produce different outputs. I think there'd
> >> only be a handful of possible values for fmt based on the current usage
> >> and that suggests just another cond form would be needed in
> >> implementing this function rather than a full-blown format string
> >> interpreter.
> >
> > It seems to me your `org--format-time' function would end up looking very
> > like what I sketched. A cond to switch between "hh:mm", "hh.mm",
> > "dd hh:mm" or "dd hh.mm" based only on the contents of the fmt argument
> > would have to check whether fmt contains 2 or 3 %-sequences, then check
> > if it contains "." or ":"
>
> Again, these are strange and very limiting rules. What if I want to
> have "5 h 32 min"? And "5,3 days"?
Good point.
> Achim didn't specify how he conceives the FMT argument. One possibility
> would be to have a placeholder-based template with, i.e. %d, %h, %m, %w
> for respectively number of days, hours, minutes and weeks. But it's
> still less flexible than functions because you need to have a fixed
> number of placeholders in every template.
Indeed. None of the format-only proposals would let me reproduce the
setup I have currently (with my earlier patch): "5d 3h" for durations
longer than a day, "3:15" for durations shorter than a day.
> I still think functions are the way to go. Three options in the
> defcustom:
>
> - One to provide regular time (i.e 14:40 or 3d 18:32)
>
> - One to provide decimal time with the highest unit available (i.e.
> 18,75 h or 2,5 d).
>
> - One free slot for an user-defined function.
I like the flexibility of functions. But one drawback of this is that you
can't produce your "5 h 32 min" or "5,3 days" examples without defining a
new function. It would be nice if tweaking just the format (without
changing the numbers themselves) could be done by changing a simple
format string.
Because the number of placeholders in a format string is fixed, I don't
see how to avoid the need for multiple format strings. Perhaps we need a
second defcustom that holds a list of format strings, to be used by the
functions in your first two choices.
The first format string for durations < 1 day (or for all durations if
this is the only string in the list), the second for durations >= 1 day.
One nice thing is that this could easily be extended in the obvious way
if one wanted to allow different formats for durations >= 1 month or
>= 1 year.
It's slightly ugly that the defaults for the format-string defcustom
would have to change depending on the value of the function defcustom. I
guess one could either have the format-string defcustom default to nil,
and use hard-coded defaults in the functions (which are overridden by a
non-nil format string value). Or put both functions and format strings
into a single defcustom, e.g. as a list with the function in the first
element.
Best,
Toby
--
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain
email: tsc25@cantab.net
web: www.dr-qubit.org
next prev parent reply other threads:[~2012-11-06 10:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 14:01 [PATCH] Separate clocksum format for durations >= 1 day Toby Cubitt
2012-11-05 9:14 ` Nicolas Goaziou
2012-11-05 10:25 ` Toby Cubitt
2012-11-05 10:47 ` Achim Gratz
2012-11-05 11:01 ` Toby Cubitt
2012-11-05 11:13 ` Achim Gratz
2012-11-05 12:10 ` Toby Cubitt
2012-11-05 12:20 ` Nicolas Goaziou
2012-11-05 12:55 ` Toby Cubitt
2012-11-05 13:14 ` Nicolas Goaziou
2012-11-05 17:40 ` Achim Gratz
2012-11-05 18:16 ` Toby Cubitt
2012-11-05 22:45 ` Nicolas Goaziou
2012-11-06 10:35 ` Toby Cubitt [this message]
2012-11-06 10:57 ` Nicolas Goaziou
2012-11-06 12:01 ` Toby Cubitt
2012-11-06 12:29 ` Nicolas Goaziou
2012-11-06 13:04 ` Toby Cubitt
2012-11-06 17:41 ` Nicolas Goaziou
2012-11-06 19:26 ` Toby Cubitt
2012-11-06 19:55 ` Nicolas Goaziou
2012-11-06 20:35 ` Toby Cubitt
2012-11-08 0:26 ` Nicolas Goaziou
2012-11-08 11:28 ` Toby Cubitt
2012-11-09 8:04 ` Nicolas Goaziou
2012-11-13 13:03 ` Toby Cubitt
2012-11-14 15:04 ` Nicolas Goaziou
2012-11-14 15:37 ` Toby Cubitt
2012-11-14 16:09 ` Nicolas Goaziou
2012-11-14 16:20 ` Toby Cubitt
2012-11-16 15:12 ` Toby Cubitt
2012-11-17 8:48 ` Nicolas Goaziou
2012-11-17 14:00 ` Toby Cubitt
2012-11-17 14:42 ` Nicolas Goaziou
2012-11-17 16:02 ` Toby Cubitt
2012-11-20 16:12 ` Mike McLean
2012-11-20 17:28 ` Toby Cubitt
2012-11-20 19:24 ` Nicolas Goaziou
2012-11-21 23:29 ` Mike McLean
2012-11-30 11:22 ` [bug] " Sebastien Vauban
2012-11-06 18:42 ` [PATCH] " Achim Gratz
2012-11-06 20:10 ` Toby Cubitt
2012-11-06 20:49 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106103546.GA9407@c3po \
--to=tsc25@cantab.net \
--cc=emacs-orgmode@gnu.org \
--cc=toby-dated-1353407730.ccda47@dr-qubit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).