emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-info: Fix docstring
@ 2016-12-14 18:26 Chunyang Xu
  2016-12-14 19:25 ` Chunyang Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Chunyang Xu @ 2016-12-14 18:26 UTC (permalink / raw)
  To: emacs-orgmode

User-agent: mu4e 0.9.18; emacs 25.1.1
* lisp/org-info.el (org-info-map-html-url): Fix docstring, there is no
  `org-info-official-gnu-document' anymore.
---
 lisp/org-info.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-info.el b/lisp/org-info.el
index d82168e..a0d9e8a 100644
--- a/lisp/org-info.el
+++ b/lisp/org-info.el
@@ -105,7 +105,7 @@ converted to use these URL's.")
 (defun org-info-map-html-url (filename)
   "Given info FILENAME, either return it (plus '.html' suffix added) or convert
 it to URL pointing to the official page on internet, e.g., use gnu.org for all
-emacs related documents. See `org-info-official-gnu-document' and
+emacs related documents. See `org-info-other-documents' and
 `org-info-other-documents' for details."
   (if (member filename org-info-emacs-documents)
       (format "http://www.gnu.org/software/emacs/manual/html_mono/%s.html"
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] org-info: Fix docstring
  2016-12-14 18:26 [PATCH] org-info: Fix docstring Chunyang Xu
@ 2016-12-14 19:25 ` Chunyang Xu
  2016-12-14 20:42   ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Chunyang Xu @ 2016-12-14 19:25 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 74 bytes --]


Never mind. The first patch was incorrect. I have attached a new patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-info-Fix-docstring.patch --]
[-- Type: text/x-patch, Size: 1069 bytes --]

From 7c5ee47741f1a9cbdb6b2df8ddad99aa95cb01e5 Mon Sep 17 00:00:00 2001
From: Chunyang Xu <mail@xuchunyang.me>
Date: Thu, 15 Dec 2016 03:19:08 +0800
Subject: [PATCH] org-info: Fix docstring

* lisp/org-info.el (org-info-map-html-url): Fix docstring, there is no
  `org-info-official-gnu-document' anymore.
---
 lisp/org-info.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-info.el b/lisp/org-info.el
index d82168e..3b363f0 100644
--- a/lisp/org-info.el
+++ b/lisp/org-info.el
@@ -105,7 +105,7 @@ converted to use these URL's.")
 (defun org-info-map-html-url (filename)
   "Given info FILENAME, either return it (plus '.html' suffix added) or convert
 it to URL pointing to the official page on internet, e.g., use gnu.org for all
-emacs related documents. See `org-info-official-gnu-document' and
+emacs related documents. See `org-info-emacs-documents' and
 `org-info-other-documents' for details."
   (if (member filename org-info-emacs-documents)
       (format "http://www.gnu.org/software/emacs/manual/html_mono/%s.html"
-- 
2.10.2


[-- Attachment #3: Type: text/plain, Size: 967 bytes --]


Chunyang Xu writes:

> User-agent: mu4e 0.9.18; emacs 25.1.1
> * lisp/org-info.el (org-info-map-html-url): Fix docstring, there is no
>   `org-info-official-gnu-document' anymore.
> ---
>  lisp/org-info.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/org-info.el b/lisp/org-info.el
> index d82168e..a0d9e8a 100644
> --- a/lisp/org-info.el
> +++ b/lisp/org-info.el
> @@ -105,7 +105,7 @@ converted to use these URL's.")
>  (defun org-info-map-html-url (filename)
>    "Given info FILENAME, either return it (plus '.html' suffix added) or convert
>  it to URL pointing to the official page on internet, e.g., use gnu.org for all
> -emacs related documents. See `org-info-official-gnu-document' and
> +emacs related documents. See `org-info-other-documents' and
>  `org-info-other-documents' for details."
>    (if (member filename org-info-emacs-documents)
>        (format "http://www.gnu.org/software/emacs/manual/html_mono/%s.html"


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] org-info: Fix docstring
  2016-12-14 19:25 ` Chunyang Xu
@ 2016-12-14 20:42   ` Nicolas Goaziou
  2016-12-14 21:44     ` Chunyang Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2016-12-14 20:42 UTC (permalink / raw)
  To: Chunyang Xu; +Cc: emacs-orgmode

Hello,

Chunyang Xu <mail@xuchunyang.me> writes:

> Never mind. The first patch was incorrect. I have attached a new
> patch.

Thank you. Since that docstring was badly formatted, I applied your
suggestion along with other changes.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] org-info: Fix docstring
  2016-12-14 20:42   ` Nicolas Goaziou
@ 2016-12-14 21:44     ` Chunyang Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Chunyang Xu @ 2016-12-14 21:44 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode


Nicolas Goaziou writes:

> Hello,
>
> Chunyang Xu <mail@xuchunyang.me> writes:
>
>> Never mind. The first patch was incorrect. I have attached a new
>> patch.
>
> Thank you. Since that docstring was badly formatted, I applied your
> suggestion along with other changes.

No problem at all. Thank you for your work.

> Regards,

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-12-14 21:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14 18:26 [PATCH] org-info: Fix docstring Chunyang Xu
2016-12-14 19:25 ` Chunyang Xu
2016-12-14 20:42   ` Nicolas Goaziou
2016-12-14 21:44     ` Chunyang Xu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).