emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rainer M Krug <Rainer@krugs.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH]: BUG fix and Add header-args property to source block info
Date: Thu, 12 Feb 2015 10:36:32 +0100	[thread overview]
Message-ID: <m2lhk331zz.fsf@krugs.de> (raw)
In-Reply-To: <m2y4o5cttc.fsf@krugs.de> (Rainer M. Krug's message of "Tue, 10 Feb 2015 22:58:39 +0100")

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]


Rainer M Krug <Rainer@krugs.de> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Rainer M Krug <Rainer@krugs.de> writes:
>>
>>> Please find attached the below described patch including the fix for the
>>> error reported - function raises error when property value is numeric.
>>
>> Looks good. Thank you.
>
> Thanks.
>
>>
>
>
>> Could you provide an appropriate commit message?
>
> Here is the patch attached with the commit message - hope it is OK.
>
>> Bonus points if you also add a test.

I think I will skip the bonus points this time - sorry.

I would be very grateful if you could submit the patch without a test.

Cheers,

Rainer

>
> Are there some guidelines on how to write tests? Never done this before...
>
> Rainer
>
>>
>> Regards,

-- 
Rainer M. Krug
email: Rainer<at>krugs<dot>de
PGP: 0x0F52F982

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 494 bytes --]

  parent reply	other threads:[~2015-02-12  9:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  9:09 [PATCH]: Add header-args property to source block info Rainer M Krug
2015-02-10 13:39 ` [PATCH]: BUG fix and " Rainer M Krug
2015-02-10 21:36   ` Nicolas Goaziou
2015-02-10 21:58     ` Rainer M Krug
2015-02-11 12:10       ` Alan Schmitt
2015-02-12  9:34         ` Rainer M Krug
2015-02-12  9:36       ` Rainer M Krug [this message]
2015-02-12 18:27         ` Charles C. Berry
2015-02-12 23:45         ` Nicolas Goaziou
2015-02-13  9:21           ` Rainer M Krug
2015-02-13  9:36             ` Sebastien Vauban
2015-02-13  9:51               ` Rainer M Krug
2015-02-10 17:58 ` [PATCH]: " Charles C. Berry
2015-02-10 20:54   ` Rainer M Krug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2lhk331zz.fsf@krugs.de \
    --to=rainer@krugs.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).