From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rainer M Krug <Rainer@krugs.de>
Subject: Re: [PATCH]: BUG fix and Add header-args property to source block
 info
Date: Thu, 12 Feb 2015 10:36:32 +0100
Message-ID: <m2lhk331zz.fsf@krugs.de>
References: <m2386e3zgv.fsf@krugs.de> <m2y4o528dl.fsf@krugs.de>
	<871tlxxxd6.fsf@nicolasgoaziou.fr> <m2y4o5cttc.fsf@krugs.de>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <r.m.krug@gmail.com>) id 1YLqCP-0004za-Fl
	for emacs-orgmode@gnu.org; Thu, 12 Feb 2015 04:36:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <r.m.krug@gmail.com>) id 1YLqCL-0006nh-8S
	for emacs-orgmode@gnu.org; Thu, 12 Feb 2015 04:36:41 -0500
Received: from mail-wi0-f181.google.com ([209.85.212.181]:33034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <r.m.krug@gmail.com>) id 1YLqCL-0006nd-2A
	for emacs-orgmode@gnu.org; Thu, 12 Feb 2015 04:36:37 -0500
Received: by mail-wi0-f181.google.com with SMTP id r20so2749891wiv.2
	for <emacs-orgmode@gnu.org>; Thu, 12 Feb 2015 01:36:36 -0800 (PST)
In-Reply-To: <m2y4o5cttc.fsf@krugs.de> (Rainer M. Krug's message of "Tue, 10
	Feb 2015 22:58:39 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Rainer M Krug <Rainer@krugs.de> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Rainer M Krug <Rainer@krugs.de> writes:
>>
>>> Please find attached the below described patch including the fix for the
>>> error reported - function raises error when property value is numeric.
>>
>> Looks good. Thank you.
>
> Thanks.
>
>>
>
>
>> Could you provide an appropriate commit message?
>
> Here is the patch attached with the commit message - hope it is OK.
>
>> Bonus points if you also add a test.

I think I will skip the bonus points this time - sorry.

I would be very grateful if you could submit the patch without a test.

Cheers,

Rainer

>
> Are there some guidelines on how to write tests? Never done this before...
>
> Rainer
>
>>
>> Regards,

=2D-=20
Rainer M. Krug
email: Rainer<at>krugs<dot>de
PGP: 0x0F52F982

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iQEcBAEBAgAGBQJU3HQgAAoJENvXNx4PUvmChkAIAI4RmsXSxA57x3Gx1sTbAGuP
L7BW5HaW9A2nzQOjdg7xo52jjzZK3r5/BAKWGreg7S33yvhUEehDG9SBiHzHp4z3
ShrvL5bND5R3JV5DrnmdO1UmnA5zGmAX8L9ukDFh1IbFIGQEF0FYBwSVUIOBwxZh
QhvB0BUgdtrmhYtclnBVasoM3Wrlfj59p05IuxVK35lneUEqY3zhcrMzdxxmYcs1
YJQvu7q+5I9F2lA5olNNgAwpnHPdAiLiFPHw7MhhqqnjNMsrthhVy/iO7b4PJJaO
C2i5DUmTjMQ8NW+d2JIFHhccIek/9AIpaKtUN/m3AhNoyhX7fRCsCbe9pUEkGFo=
=OQof
-----END PGP SIGNATURE-----
--=-=-=--