From: "Charles C. Berry" <ccberry@ucsd.edu>
To: Rainer M Krug <Rainer@krugs.de>
Cc: emacs-orgmode@gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH]: BUG fix and Add header-args property to source block info
Date: Thu, 12 Feb 2015 10:27:43 -0800 [thread overview]
Message-ID: <alpine.OSX.2.00.1502120954250.1374@charlessmacbook> (raw)
In-Reply-To: <m2lhk331zz.fsf@krugs.de>
On Thu, 12 Feb 2015, Rainer M Krug wrote:
>
> Rainer M Krug <Rainer@krugs.de> writes:
>
>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>
>>> Hello,
>>>
>>> Rainer M Krug <Rainer@krugs.de> writes:
>>>
>>>> Please find attached the below described patch including the fix for the
>>>> error reported - function raises error when property value is numeric.
>>>
>>> Looks good. Thank you.
>>
>> Thanks.
>>
>>>
>>
>>
>>> Could you provide an appropriate commit message?
>>
>> Here is the patch attached with the commit message - hope it is OK.
>>
>>> Bonus points if you also add a test.
>
> I think I will skip the bonus points this time - sorry.
>
> I would be very grateful if you could submit the patch without a test.
>
> Cheers,
>
> Rainer
>
>>
>> Are there some guidelines on how to write tests? Never done this before...
Alan's suggestions are good. To which I might add browse `testing/README'.
Try this. Evaluate these blocks:
#+BEGIN_SRC emacs-lisp :var here=(buffer-file-name)
(add-to-list 'load-path (file-name-directory here))
(require 'org-test)
#+END_SRC
#+BEGIN_SRC emacs-lisp
(ert-deftest test-org-babel/view-src-block-info-for-identity ()
"Check `(identity #o444)' in header-args property."
(org-test-with-temp-text
"#+PROPERTY: header-args :tangle-mode (identity #o444)
,#+begin_src emacs-lisp
(+ 1 2)
,#+end_src"
(org-mode-restart)
(forward-line 2)
(org-babel-view-src-block-info)))
#+END_SRC
Then do ` M-x ert RET t RET' and a window should pop up showing that
you either passed (with your patch) or failed (without your patch) 1
test.
If that much works, then submit a patch for testing/lisp/test-ob.el.
HTH,
Chuck
next prev parent reply other threads:[~2015-02-12 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 9:09 [PATCH]: Add header-args property to source block info Rainer M Krug
2015-02-10 13:39 ` [PATCH]: BUG fix and " Rainer M Krug
2015-02-10 21:36 ` Nicolas Goaziou
2015-02-10 21:58 ` Rainer M Krug
2015-02-11 12:10 ` Alan Schmitt
2015-02-12 9:34 ` Rainer M Krug
2015-02-12 9:36 ` Rainer M Krug
2015-02-12 18:27 ` Charles C. Berry [this message]
2015-02-12 23:45 ` Nicolas Goaziou
2015-02-13 9:21 ` Rainer M Krug
2015-02-13 9:36 ` Sebastien Vauban
2015-02-13 9:51 ` Rainer M Krug
2015-02-10 17:58 ` [PATCH]: " Charles C. Berry
2015-02-10 20:54 ` Rainer M Krug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.1502120954250.1374@charlessmacbook \
--to=ccberry@ucsd.edu \
--cc=Rainer@krugs.de \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).