From: Martyn Jago <martyn.jago@btinternet.com>
To: emacs-orgmode@gnu.org
Subject: Re: [patch][babel] `org-babel-result-end' bug fix and regression tests
Date: Fri, 06 Jan 2012 18:37:06 +0000 [thread overview]
Message-ID: <m2fwfsr831.fsf@btinternet.com> (raw)
In-Reply-To: 87ipkozpsh.fsf@gmx.com
Eric Schulte <eric.schulte@gmx.com> writes:
Hi Eric
> Hi Martyn,
>
> Unfortunately there is no way to remove raw results because there is no
> way to know where the results end. While your patch will certainly work
> most of the time, it will not work in cases where the results includes
> an empty line, and ultimately I think any attempt to remove raw results
> will result in confusion.
Yes I appreciate that would be a problem if there were empty lines. I just
thought that most of the time is better than none of the time, but I
understand your choice. Certainly wrap works fine.
I have noticed one small issue regarding :results wrap, which is that an
extra newline is appended to the end of the result each time
`org-babel-execute-src-block' is executed. I imagine this can be safely
removed?
There are a few other minor issues also with `org-babel-remove-results'
that probably should be fixed at some time (regarding append and
prepend).
> I think this patch should not be applied (although maybe some of the
> test cases could still be useful).
All the tests supplied with the exception of
`test-ob/org-babel-remove-result--results-raw' will still pass without
the change.
Best, Martyn
next prev parent reply other threads:[~2012-01-06 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 17:31 [patch][babel] `org-babel-result-end' bug fix and regression tests Martyn Jago
2012-01-06 17:47 ` Eric Schulte
2012-01-06 18:37 ` Martyn Jago [this message]
2012-01-06 18:52 ` Eric Schulte
2012-01-06 19:41 ` Martyn Jago
2012-01-06 20:11 ` Eric Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fwfsr831.fsf@btinternet.com \
--to=martyn.jago@btinternet.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).