From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martyn Jago Subject: Re: [patch][babel] `org-babel-result-end' bug fix and regression tests Date: Fri, 06 Jan 2012 18:37:06 +0000 Message-ID: References: <87ipkozpsh.fsf@gmx.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:57243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjEfN-0000x6-AV for emacs-orgmode@gnu.org; Fri, 06 Jan 2012 13:37:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjEfL-0000wZ-Ih for emacs-orgmode@gnu.org; Fri, 06 Jan 2012 13:37:25 -0500 Received: from lo.gmane.org ([80.91.229.12]:42537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjEfL-0000wA-5V for emacs-orgmode@gnu.org; Fri, 06 Jan 2012 13:37:23 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RjEfJ-0005U8-3H for emacs-orgmode@gnu.org; Fri, 06 Jan 2012 19:37:21 +0100 Received: from 88-96-171-138.dsl.zen.co.uk ([88.96.171.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Jan 2012 19:37:21 +0100 Received: from martyn.jago by 88-96-171-138.dsl.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Jan 2012 19:37:21 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Eric Schulte writes: Hi Eric > Hi Martyn, > > Unfortunately there is no way to remove raw results because there is no > way to know where the results end. While your patch will certainly work > most of the time, it will not work in cases where the results includes > an empty line, and ultimately I think any attempt to remove raw results > will result in confusion. Yes I appreciate that would be a problem if there were empty lines. I just thought that most of the time is better than none of the time, but I understand your choice. Certainly wrap works fine. I have noticed one small issue regarding :results wrap, which is that an extra newline is appended to the end of the result each time `org-babel-execute-src-block' is executed. I imagine this can be safely removed? There are a few other minor issues also with `org-babel-remove-results' that probably should be fixed at some time (regarding append and prepend). > I think this patch should not be applied (although maybe some of the > test cases could still be useful). All the tests supplied with the exception of `test-ob/org-babel-remove-result--results-raw' will still pass without the change. Best, Martyn