emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <eric.schulte@gmx.com>
To: Martyn Jago <martyn.jago@btinternet.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch][babel] `org-babel-result-end' bug fix and regression tests
Date: Fri, 06 Jan 2012 10:47:26 -0700	[thread overview]
Message-ID: <87ipkozpsh.fsf@gmx.com> (raw)
In-Reply-To: <m2k454rb3l.fsf@btinternet.com> (Martyn Jago's message of "Fri, 06 Jan 2012 17:31:58 +0000")

Hi Martyn,

Unfortunately there is no way to remove raw results because there is no
way to know where the results end.  While your patch will certainly work
most of the time, it will not work in cases where the results includes
an empty line, and ultimately I think any attempt to remove raw results
will result in confusion.

If removable raw results are desired then the ":results wrap" option may
be used.  I believe this is mentioned in the manual (if not it should
be).

I think this patch should not be applied (although maybe some of the
test cases could still be useful).

Thanks,

Martyn Jago <martyn.jago@btinternet.com> writes:

> `org-babel-result-end' bug fix and `org-babel-remove-result' regression tests.
>
> * lisp/ob.el:
>
> The code block below will currently act as though :results prepend 
> is set. This is due to `org-babel-result-end' being unable to
> find the correct end of a raw result. This patch fixes that.
>
> #+begin_src emacs-lisp :results raw
> "a line"
> #+end_src
>
> #+results:
> a line
> a line
>
> * testing/lisp/test-ob.el:
>
> Several regression tests that test the correct (multiple) execution of
> code blocks in the various results formats. The tests also test that
> 'org-babel-remove-result' correctly removes the result.
>
> Best, Martyn
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

next prev parent reply	other threads:[~2012-01-06 17:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 17:31 [patch][babel] `org-babel-result-end' bug fix and regression tests Martyn Jago
2012-01-06 17:47 ` Eric Schulte [this message]
2012-01-06 18:37   ` Martyn Jago
2012-01-06 18:52     ` Eric Schulte
2012-01-06 19:41       ` Martyn Jago
2012-01-06 20:11         ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipkozpsh.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=martyn.jago@btinternet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).