From: Jim Porter <jporterbugs@gmail.com>
To: Drew Adams <drew.adams@oracle.com>, Ihor Radchenko <yantar92@posteo.net>
Cc: "eliz@gnu.org" <eliz@gnu.org>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>,
"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: RE: [External] : Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)
Date: Mon, 6 May 2024 18:08:06 -0700 [thread overview]
Message-ID: <cd65f3f6-782e-55d7-63d4-c3b7d972daf8@gmail.com> (raw)
In-Reply-To: <SJ0PR10MB5488187562A0FEE7F16EE324F31A2@SJ0PR10MB5488.namprd10.prod.outlook.com>
On 4/30/2024 2:10 PM, Drew Adams wrote:
>> I've also fixed a bug in EWW and bug-reference-mode
>> where it would return nil for (thing-at-point 'url)
>> if point was at the *end* of a URL.
>
> By "at the end" I assume you really mean just
> _after_ a URL, i.e., no longer on/at the URL.
>
> FWIW, that's actually _superior_ behavior.
>
> Unfortunately however, Emacs has chosen the
> behavior you describe here:
>
>> It's now consistent with how 'thing-at-point'
>> works by default.
>
>> (If you have two consecutive URLs and point
>> is between them...it'll prefer the second one.)
>
> Which is better! It's what "at point" means.
[snip]
> See bug #9300, " `bounds-of-thing-at-point'
> does not return nil when just after THING".
I agree overall that your proposed behavior is more correct, and it's
probably how I'd have implemented 'thing-at-point' if I were doing it
from scratch. However, I think an even worse outcome than
"thing-at-point looks at point or before-point" is "sometimes
thing-at-point just looks at point, and other times it looks at point or
before-point" (which is what it does today).
I'd even be open to something like a 'thing-at-point-is-strict' defvar
that people could let-bind as wanted, but I'm not going to *argue* for
that myself.
Ultimately though, this patch is really just about providing the
necessary defcustoms for org-mode to be able to use 'thing-at-point'
(and for Ihor to feel ok about it ;)). Changing 'thing-at-point's
behavior should probably be handled separately, especially since there'd
be an uphill battle to revisit the decision in bug#9300.
next prev parent reply other threads:[~2024-05-07 1:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:45 [PATCH] Add support for 'thing-at-point' to get URL at point Jim Porter
2023-11-06 19:56 ` Jim Porter
2023-11-06 20:11 ` Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point) Ihor Radchenko
2023-11-06 20:53 ` Jim Porter
2024-02-05 15:07 ` Ihor Radchenko
2024-02-05 22:44 ` Jim Porter
2024-02-05 22:56 ` Ihor Radchenko
2024-02-06 12:26 ` Eli Zaretskii
2024-02-06 12:38 ` Ihor Radchenko
2024-02-06 12:47 ` Eli Zaretskii
2024-04-12 12:41 ` Ihor Radchenko
2024-04-12 22:30 ` Jim Porter
2024-04-29 4:26 ` Jim Porter
2024-04-29 18:14 ` Ihor Radchenko
2024-04-30 4:42 ` Jim Porter
2024-04-30 11:39 ` Ihor Radchenko
2024-04-30 18:27 ` Jim Porter
2024-04-30 21:10 ` [External] : " Drew Adams
2024-05-07 1:08 ` Jim Porter [this message]
2024-05-07 1:52 ` Drew Adams
2024-05-07 12:20 ` Eli Zaretskii
2024-05-07 15:16 ` Drew Adams
2024-05-07 16:10 ` Jim Porter
2024-05-07 18:01 ` Eli Zaretskii
2024-05-18 8:26 ` Eli Zaretskii
[not found] <CAO48Bk97scjnRwHTegBHDQC61E0EOtgvZaKLsz27qYyvamL2Aw@mail.gmail.com>
[not found] ` <SJ0PR10MB5488A3BE62A58A2E7BF7331CF3E52@SJ0PR10MB5488.namprd10.prod.outlook.com>
2024-05-09 5:46 ` Re: [External] : " Pedro Andres Aranda Gutierrez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd65f3f6-782e-55d7-63d4-c3b7d972daf8@gmail.com \
--to=jporterbugs@gmail.com \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).