From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: yantar92@posteo.net, emacs-devel@gnu.org, emacs-orgmode@gnu.org
Subject: Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)
Date: Sat, 18 May 2024 11:26:29 +0300 [thread overview]
Message-ID: <868r07fruy.fsf@gnu.org> (raw)
In-Reply-To: <2f344439-d0d6-a3e5-963c-773bb5c833d6@gmail.com> (message from Jim Porter on Tue, 30 Apr 2024 11:27:04 -0700)
> Date: Tue, 30 Apr 2024 11:27:04 -0700
> Cc: eliz@gnu.org, emacs-devel@gnu.org, emacs-orgmode@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 4/30/2024 4:39 AM, Ihor Radchenko wrote:
> > What happens if you have multiple providers for an URL?
> > You add the provider to the end, so it will have the lower priority in
> > this scenario. I guess that you want the opposite - EWW provider to take
> > precedence. Same for other changes.
>
> That's probably reasonable. I was just keeping things the way they were
> historically here, but we might as well fix this now.
>
> > It would make sense to add tests for "first wins" behaviour.
>
> Done.
>
> I've also fixed a bug in EWW and bug-reference-mode where it would
> return nil for (thing-at-point 'url) if point was at the *end* of a URL.
> It's now consistent with how 'thing-at-point' works by default. (If you
> have two consecutive URLs and point is between them - only possible with
> the custom provider function, I think - it'll prefer the second one.)
I think you can install this now.
next prev parent reply other threads:[~2024-05-18 8:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:45 [PATCH] Add support for 'thing-at-point' to get URL at point Jim Porter
2023-11-06 19:56 ` Jim Porter
2023-11-06 20:11 ` Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point) Ihor Radchenko
2023-11-06 20:53 ` Jim Porter
2024-02-05 15:07 ` Ihor Radchenko
2024-02-05 22:44 ` Jim Porter
2024-02-05 22:56 ` Ihor Radchenko
2024-02-06 12:26 ` Eli Zaretskii
2024-02-06 12:38 ` Ihor Radchenko
2024-02-06 12:47 ` Eli Zaretskii
2024-04-12 12:41 ` Ihor Radchenko
2024-04-12 22:30 ` Jim Porter
2024-04-29 4:26 ` Jim Porter
2024-04-29 18:14 ` Ihor Radchenko
2024-04-30 4:42 ` Jim Porter
2024-04-30 11:39 ` Ihor Radchenko
2024-04-30 18:27 ` Jim Porter
2024-04-30 21:10 ` [External] : " Drew Adams
2024-05-07 1:08 ` Jim Porter
2024-05-07 1:52 ` Drew Adams
2024-05-07 12:20 ` Eli Zaretskii
2024-05-07 15:16 ` Drew Adams
2024-05-07 16:10 ` Jim Porter
2024-05-07 18:01 ` Eli Zaretskii
2024-05-18 8:26 ` Eli Zaretskii [this message]
2024-05-20 1:34 ` Jim Porter
2024-05-20 2:33 ` Jim Porter
2024-05-20 10:41 ` Ihor Radchenko
2024-05-20 20:32 ` Jim Porter
2024-05-25 14:09 ` Ihor Radchenko
2024-05-26 5:33 ` Jim Porter
2024-05-26 12:56 ` Ihor Radchenko
2024-05-26 17:03 ` Jim Porter
2024-05-21 10:32 ` Adding custom providers for thingatpt.el Max Nikulin
2024-05-21 16:24 ` Jim Porter
2024-05-22 13:30 ` Max Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868r07fruy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).