emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* {{{macro}}} expansion not working properly for docbook export
@ 2009-05-19 14:59 Dale Smith
  2009-05-20  7:11 ` Baoqiu Cui
  0 siblings, 1 reply; 5+ messages in thread
From: Dale Smith @ 2009-05-19 14:59 UTC (permalink / raw)
  To: emacs-orgmode

{{{maxro}}} expansion does not happen for docbook export until an html
export is done.  After that, macros seems to be expanded properly for
docbook export.

Thanks!
  -Dale
-- 
Dale P. Smith
dales@vtiinstruments.com
216-447-4059 x2018
216-447-8951 FAX

(Company mandated disclaimer follows...)

The information in this e-mail and any attachments is intended solely
for use by the recipient(s) to whom this e-mail is addressed and may
contain confidential and/or privileged information which is exempt
from disclosure.  If you are not an intended recipient, or an employee
or agent responsible for delivering this message to the intended
recipient, you are hereby notified that you have received this e-mail
and any attachments in error and that dissemination, distribution,
review or copying of this e-mail and its attachments is strictly
prohibited.  If you have received this e-mail in error, please notify
the sender immediately and delete all electronic and paper copies of
this e-mail as well as any attachments.
Thank you.

http://www.vtiinstruments.com/images/vtiemaillogo.gif

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: {{{macro}}} expansion not working properly for docbook export
  2009-05-19 14:59 {{{macro}}} expansion not working properly for docbook export Dale Smith
@ 2009-05-20  7:11 ` Baoqiu Cui
  2009-05-20 14:11   ` Dale Smith
  0 siblings, 1 reply; 5+ messages in thread
From: Baoqiu Cui @ 2009-05-20  7:11 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi Dale,

Dale Smith <dsmith@vtiinstruments.com> writes:

> {{{maxro}}} expansion does not happen for docbook export until an html
> export is done.  After that, macros seems to be expanded properly for
> docbook export.

Thanks for reporting this bug.  For some reason I missed the coverage of
macro support in DocBook exporter, and the bug was caused by an
"optimization" that I thought I did in the code...  Variable
org-export-opt-plist should have been set but it was not in DocBook
exporter.

Attached please find the patch for the fix.  Please let me know if it
works.

Thanks,
Baoqiu


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: docbook-macro.diff --]
[-- Type: text/x-patch, Size: 610 bytes --]

diff --git a/lisp/org-docbook.el b/lisp/org-docbook.el
index eab30d8..11f65e3 100644
--- a/lisp/org-docbook.el
+++ b/lisp/org-docbook.el
@@ -419,9 +419,10 @@ publishing directory."
 			     (+ (funcall outline-level)
 				(if org-odd-levels-only 1 0)))
 			 0))
-	 (opt-plist (if subtree-p
-			(org-export-add-subtree-options opt-plist rbeg)
-		      opt-plist))
+	 (opt-plist (setq org-export-opt-plist
+			  (if subtree-p
+			      (org-export-add-subtree-options opt-plist rbeg)
+			    opt-plist)))
 	 ;; The following two are dynamically scoped into other
 	 ;; routines below.
 	 (org-current-export-dir

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Re: {{{macro}}} expansion not working properly for docbook export
  2009-05-20  7:11 ` Baoqiu Cui
@ 2009-05-20 14:11   ` Dale Smith
  2009-05-20 17:10     ` Baoqiu Cui
  0 siblings, 1 reply; 5+ messages in thread
From: Dale Smith @ 2009-05-20 14:11 UTC (permalink / raw)
  To: Baoqiu Cui; +Cc: emacs-orgmode@gnu.org

Baoqiu Cui <cbaoqiu@yahoo.com> writes:

> Thanks for reporting this bug.  For some reason I missed the coverage of
> macro support in DocBook exporter, and the bug was caused by an
> "optimization" that I thought I did in the code...  Variable
> org-export-opt-plist should have been set but it was not in DocBook
> exporter.
>
> Attached please find the patch for the fix.  Please let me know if it
> works.

Works great!

This bug may be related to another I noticed.  I don't yet have a clear
picture yet of what is (not) going on.  Basically, the time reported
by modification time was just plain wrong.  By over a day.  And I
*know* I just saved the file.

I'm guessing now that the property was cached.  If so, that property
should *not* be. It really needs to be fresh every time an export is
done.

-Dale

-- 
Dale P. Smith
dales@vtiinstruments.com
216-447-4059 x2018
216-447-8951 FAX

(Company mandated disclaimer follows...)

The information in this e-mail and any attachments is intended solely
for use by the recipient(s) to whom this e-mail is addressed and may
contain confidential and/or privileged information which is exempt
from disclosure.  If you are not an intended recipient, or an employee
or agent responsible for delivering this message to the intended
recipient, you are hereby notified that you have received this e-mail
and any attachments in error and that dissemination, distribution,
review or copying of this e-mail and its attachments is strictly
prohibited.  If you have received this e-mail in error, please notify
the sender immediately and delete all electronic and paper copies of
this e-mail as well as any attachments.
Thank you.

http://www.vtiinstruments.com/images/vtiemaillogo.gif

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: {{{macro}}} expansion not working properly for docbook export
  2009-05-20 14:11   ` Dale Smith
@ 2009-05-20 17:10     ` Baoqiu Cui
  2009-05-20 18:23       ` Dale Smith
  0 siblings, 1 reply; 5+ messages in thread
From: Baoqiu Cui @ 2009-05-20 17:10 UTC (permalink / raw)
  To: emacs-orgmode

Dale Smith <dsmith@vtiinstruments.com> writes:

> Baoqiu Cui <cbaoqiu@yahoo.com> writes:
>
>> Thanks for reporting this bug.  For some reason I missed the coverage of
>> macro support in DocBook exporter, and the bug was caused by an
>> "optimization" that I thought I did in the code...  Variable
>> org-export-opt-plist should have been set but it was not in DocBook
>> exporter.
>>
>> Attached please find the patch for the fix.  Please let me know if it
>> works.
>
> Works great!

Thanks for the confirmation.

> This bug may be related to another I noticed.  I don't yet have a clear
> picture yet of what is (not) going on.  Basically, the time reported
> by modification time was just plain wrong.  By over a day.  And I
> *know* I just saved the file.
>
> I'm guessing now that the property was cached.  If so, that property
> should *not* be. It really needs to be fresh every time an export is
> done.

I am not able to reproduce this problem.  I tried adding the following
line in an Org file

   {{{modification-time(%Y-%m-%d %H:%M:%S)}}}

and then tried to save the file multiple times with minor changes, and
was able to consistently get the correct time in the exported DocBook
file.

Baoqiu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Re: {{{macro}}} expansion not working properly for docbook export
  2009-05-20 17:10     ` Baoqiu Cui
@ 2009-05-20 18:23       ` Dale Smith
  0 siblings, 0 replies; 5+ messages in thread
From: Dale Smith @ 2009-05-20 18:23 UTC (permalink / raw)
  To: Baoqiu Cui; +Cc: emacs-orgmode@gnu.org

Baoqiu Cui <cbaoqiu@yahoo.com> writes:

>> This bug may be related to another I noticed.  I don't yet have a clear
>> picture yet of what is (not) going on.  Basically, the time reported
>> by modification time was just plain wrong.  By over a day.  And I
>> *know* I just saved the file.
>>
>> I'm guessing now that the property was cached.  If so, that property
>> should *not* be. It really needs to be fresh every time an export is
>> done.
>
> I am not able to reproduce this problem.  I tried adding the following
> line in an Org file
>
>    {{{modification-time(%Y-%m-%d %H:%M:%S)}}}
>
> and then tried to save the file multiple times with minor changes, and
> was able to consistently get the correct time in the exported DocBook
> file.

Indeed is *is* now working correctly.  So I guessing that the time was
"frozen" at the point I did an html export.  Now that the docbook
exporter is generating the properties, the time is being updated.
Yay!

Thanks again,
  -Dale

-- 
Dale P. Smith
dales@vtiinstruments.com
216-447-4059 x2018
216-447-8951 FAX

(Company mandated disclaimer follows...)

The information in this e-mail and any attachments is intended solely
for use by the recipient(s) to whom this e-mail is addressed and may
contain confidential and/or privileged information which is exempt
from disclosure.  If you are not an intended recipient, or an employee
or agent responsible for delivering this message to the intended
recipient, you are hereby notified that you have received this e-mail
and any attachments in error and that dissemination, distribution,
review or copying of this e-mail and its attachments is strictly
prohibited.  If you have received this e-mail in error, please notify
the sender immediately and delete all electronic and paper copies of
this e-mail as well as any attachments.
Thank you.

http://www.vtiinstruments.com/images/vtiemaillogo.gif

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-05-20 19:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-19 14:59 {{{macro}}} expansion not working properly for docbook export Dale Smith
2009-05-20  7:11 ` Baoqiu Cui
2009-05-20 14:11   ` Dale Smith
2009-05-20 17:10     ` Baoqiu Cui
2009-05-20 18:23       ` Dale Smith

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).