emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* patch to org-refile for more accurate completing-read
@ 2012-01-27 14:44 Le Wang
  2012-01-27 23:42 ` Bernt Hansen
  0 siblings, 1 reply; 4+ messages in thread
From: Le Wang @ 2012-01-27 14:44 UTC (permalink / raw)
  To: Orgmode Mailing List

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Here: https://gist.github.com/1689071

When we are using using refile as navigation, require must-match regardless
of org-refile-allow-creating-parent-nodes.

-- 
Le

[-- Attachment #2: Type: text/html, Size: 244 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch to org-refile for more accurate completing-read
  2012-01-27 14:44 patch to org-refile for more accurate completing-read Le Wang
@ 2012-01-27 23:42 ` Bernt Hansen
  2012-01-28  8:51   ` Le Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Bernt Hansen @ 2012-01-27 23:42 UTC (permalink / raw)
  To: Le Wang; +Cc: Orgmode Mailing List

Le Wang <l26wang@gmail.com> writes:

> Here: https://gist.github.com/1689071
>
> When we are using using refile as navigation, require must-match
> regardless of org-refile-allow-creating-parent-nodes.

Hi,

I suggest you post the patch to the mailing list as an attachment so
  1) we can read it inline and comment on it without having to go find
     it on the web
  2) it will get automatically picked up by the patchwork patch tracker
     so it can be easily applied to the source
  3) it will forever be in the mailing list archive

Regards,
Bernt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch to org-refile for more accurate completing-read
  2012-01-27 23:42 ` Bernt Hansen
@ 2012-01-28  8:51   ` Le Wang
  2012-02-08 19:21     ` David Maus
  0 siblings, 1 reply; 4+ messages in thread
From: Le Wang @ 2012-01-28  8:51 UTC (permalink / raw)
  To: Bernt Hansen; +Cc: Orgmode Mailing List


[-- Attachment #1.1: Type: text/plain, Size: 672 bytes --]

Sure.

On Sat, Jan 28, 2012 at 7:42 AM, Bernt Hansen <bernt@norang.ca> wrote:

> Le Wang <l26wang@gmail.com> writes:
>
> > Here: https://gist.github.com/1689071
> >
> > When we are using using refile as navigation, require must-match
> > regardless of org-refile-allow-creating-parent-nodes.
>
> Hi,
>
> I suggest you post the patch to the mailing list as an attachment so
>  1) we can read it inline and comment on it without having to go find
>     it on the web
>  2) it will get automatically picked up by the patchwork patch tracker
>     so it can be easily applied to the source
>  3) it will forever be in the mailing list archive
>
> Regards,
> Bernt
>



-- 
Le

[-- Attachment #1.2: Type: text/html, Size: 1151 bytes --]

[-- Attachment #2: org.el.diff --]
[-- Type: application/octet-stream, Size: 459 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 7a68b73..ccdcace 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10625,7 +10625,8 @@ prefix argument (`C-u C-u C-u C-c C-w')."
 				       (t (concat "Refile subtree \""
 						  heading-text "\" to")))
 				 default-buffer
-				 org-refile-allow-creating-parent-nodes
+				 (and (not (equal '(4) goto))
+				      org-refile-allow-creating-parent-nodes)
 				 goto))))))
 	  (setq file (nth 1 it)
 		re (nth 2 it)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch to org-refile for more accurate completing-read
  2012-01-28  8:51   ` Le Wang
@ 2012-02-08 19:21     ` David Maus
  0 siblings, 0 replies; 4+ messages in thread
From: David Maus @ 2012-02-08 19:21 UTC (permalink / raw)
  To: Orgmode Mailing List

[-- Attachment #1: Type: text/plain, Size: 68 bytes --]

Resend Le Wang's patch as text/plain, so patchtracker picks it up.


[-- Attachment #2: org.el.diff --]
[-- Type: text/plain, Size: 459 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 7a68b73..ccdcace 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10625,7 +10625,8 @@ prefix argument (`C-u C-u C-u C-c C-w')."
 				       (t (concat "Refile subtree \""
 						  heading-text "\" to")))
 				 default-buffer
-				 org-refile-allow-creating-parent-nodes
+				 (and (not (equal '(4) goto))
+				      org-refile-allow-creating-parent-nodes)
 				 goto))))))
 	  (setq file (nth 1 it)
 		re (nth 2 it)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-08 19:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-27 14:44 patch to org-refile for more accurate completing-read Le Wang
2012-01-27 23:42 ` Bernt Hansen
2012-01-28  8:51   ` Le Wang
2012-02-08 19:21     ` David Maus

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).